Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Warp Sync the default Sync mode #34

Open
bkchr opened this issue Sep 13, 2022 · 3 comments
Open

Make Warp Sync the default Sync mode #34

bkchr opened this issue Sep 13, 2022 · 3 comments
Labels
I5-enhancement An additional feature request.

Comments

@bkchr
Copy link
Member

bkchr commented Sep 13, 2022

We should make warp sync the default sync mode. Only if someone starts with --state-pruning archive we should switch to the catch up sync mode, aka download and execute every block.

This depends on: #35
@nazar-pc
Copy link
Contributor

I am a bit concerned about this because it implies a bunch of assumptions about properties of the chain like consensus and with Substrate being a generic framework it would be unfortunate to have our chain broken because the default sync is no longer compatible with it.

I'm not sure what is the scope of this issue though, maybe we can patch it and override the default mechanism somehow even after this change 🤷

@bkchr
Copy link
Member Author

bkchr commented Sep 17, 2022

Good point and clearly something that should be considered while doing this :)

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/community-bootnodes-and-snapshot-providers/630/1

@bkchr bkchr mentioned this issue Jun 3, 2023
Open
@the-right-joyce the-right-joyce transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. and removed J0-enhancement labels Aug 25, 2023
Neopallium pushed a commit to PolymeshAssociation/polkadot-sdk that referenced this issue Dec 8, 2023
@HenriqueNogara @Neopallium
Add v10 migration - New deposit_account field to ContractInfo (parity…
743087f 
…tech#34)

Signed-off-by: Robert G. Jakabosky <[email protected]>
lexnv pushed a commit that referenced this issue Apr 3, 2024
@jsdw
Merge pull request #34 from paritytech/dependabot/github_actions/peac…
cf86b0d 
…eiris/actions-gh-pages-3.9.3

Bump peaceiris/actions-gh-pages from 3.8.0 to 3.9.3
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
245030a 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
d779838 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
f900b0f 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
9b42110 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
72f491d 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
e173bc9 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
22e25b8 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
23a7655 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
653df05 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @serban300
Reward submitters only when submitted block is finalized (paritytech#34)
1919f0d 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @bkchr
Reward submitters only when submitted block is finalized (paritytech#34)
d904a28 
* reward submitters on finalization

* fix grumble

* make submitter part of ImportContext
liuchengxu added a commit to subcoin-project/polkadot-sdk that referenced this issue Sep 20, 2024
@liuchengxu
Fix system rpc (paritytech#34)
9ab54e1 
* Remove dummy build_system_rpc_future()

* Add protocol id to chain spec

* Fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I5-enhancement An additional feature request.
Projects
Networking
Status: Backlog 🗒
SDK Node
Status: backlog
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nazar-pc @bkchr @altonen @the-right-joyce @Polkadot-Forum