PVF worker: consider clone instead of fork
#2162
Labels
T0-node
This PR/Issue is related to the topic “node”.
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 21, 2024
@mrcnski Done the change on the prepare worker, once the prepare worker part is good I'll do the same for the execute worker. This is based on https://github.com/koute/polkavm/blob/11beebd06276ce9b84f335350138479e714f6caf/crates/polkavm/src/sandbox/linux.rs#L711. ## TODO - [x] Add a check for this capability at startup - [x] Add prdoc mentioning the new Secure Validator Mode (optional) requirement. ## Related Closes #2162 --------- Co-authored-by: Marcin S <[email protected]>
github-project-automation
bot
moved this from Review in progress
to Completed
in parachains team board
bkontur
pushed a commit
that referenced
this issue
May 10, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 14, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 15, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 15, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 15, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 16, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 17, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 17, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
svyatonik
added a commit
that referenced
this issue
May 17, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 20, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 21, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 22, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
bkontur
pushed a commit
that referenced
this issue
May 23, 2024
* Revert "Revert new client (#2153)" This reverts commit 17cf7b596170419a1e9b9d39d7e329acdb1a87de. * add comment re cache to CachingClient (#2162) * do not wait for reader when sending items (#2163) * Use unsync cache + async-aware sync primitives (#2164) * use unsync cache + async-aware sync primitives * clippy * trigger CI * Revert "trigger CI" This reverts commit b5c1405492409b85abf552ba0b089c000824f722.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think
forkis okay for now, but in a follow-up we should replace it withcloneand pass in some arguments for sandboxing, as seen here:https://github.com/koute/polkavm/blob/11beebd06276ce9b84f335350138479e714f6caf/crates/polkavm/src/sandbox/linux.rs#L711
Originally posted by @mrcnski in #1685 (comment)
The text was updated successfully, but these errors were encountered: