Validate unsigned -> pallet::authorize by antkve · Pull Request #194 · paritytech/polkadot-bulletin-chain

antkve · 2026-01-21T11:59:58Z

TODO

~~think about authorize_preimage and ProvideCidCodec and sp_io::hashing::blake2_256(data) in check_unsigned~~

bkontur · 2026-01-22T12:54:29Z

@antkve please rebase/merge with main

antkve · 2026-01-22T14:35:17Z

@antkve please rebase/merge with main

Done. By the way I'm not sure if we want to keep backwards compatibility like in the frame system upgrade? Can add that back in.

bkontur · 2026-01-22T22:57:29Z

-		pub fn store(_origin: OriginFor<T>, data: Vec<u8>) -> DispatchResult {
+		#[pallet::authorize(|_source, data| {
+			Pallet::<T>::to_validity_with_refund(
+				Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::Validate),


@antkve Could we just use here PreDispatch flow, which modifies authorizations and remove all the is_authorized handling from the call?

Suggested change

Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::Validate),

Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::PreDispatch),

bkontur · 2026-01-22T23:15:57Z

@antkve please, check this fmt and fix compilation

franciscoaguirre · 2026-02-13T00:45:04Z

@antkve I added the feeless_if validation

* Use GitHub Actions matrix for integration tests Run Westend parachain and Polkadot solochain tests in parallel instead of sequentially, eliminating ~75 lines of duplication and cutting CI wall time roughly in half. Each runtime gets its own isolated runner, avoiding flaky cross-runtime state issues (#237). * Reuse runtimes-matrix.json for integration test matrix Instead of hardcoding the runtime list in the workflow, read from scripts/runtimes-matrix.json and filter by a new `integration_tests` flag. This keeps the single source of truth for runtime definitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add summary job for Integration Tests status check The matrix job reports per-runtime check names (e.g. "Integration Tests (bulletin-polkadot)") which don't match the branch protection rule expecting a single "Integration Tests" status. Add a summary job that aggregates matrix results under that exact name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Load env vars in Setup job to fix cache key resolution The Setup job uses POLKADOT_SDK_VERSION and ZOMBIENET_VERSION in cache keys, but these are defined in .github/env. Without loading that file, the cache keys resolve to empty strings causing cache misses every run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use GITHUB_ENV for RUNTIME_PACKAGE instead of per-step matrix refs Set RUNTIME_PACKAGE once in $GITHUB_ENV alongside TEST_DIR, then reference both as plain env vars in all subsequent steps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>

bkontur · 2026-02-17T10:04:37Z

+	tx::SubmittableTransaction,
+	OnlineClient,
+};
+use subxt_core::{


@antkve I don't remember, but what was exactly the error with PAPI? That it did not work without ValidateUnsigned trait in runtime?

Yep that's it, I guess this is fixed now though? Hope it is because trying to get it working in subxt is doing my head in

bkontur · 2026-02-19T18:32:26Z

@antkve please, rebase, no ProvideCidConfig extension is needed, so unsigned transaction should work or PAPI has problem without ValidateUnsigned?

bkontur · 2026-03-04T13:21:16Z

@antkve please rebase this, I am almost coming to this with #247

bkontur · 2026-03-19T16:17:44Z

@antkve please, rebase, no ProvideCidConfig extension is needed, so unsigned transaction should work or PAPI has problem without ValidateUnsigned?

@antkve please 👆 ?

bkontur · 2026-03-26T16:04:08Z

-            throw new Error(`txOpts not supported for unsigned transactions (getBareTx doesn't accept options). See: https://github.com/polkadot-api/polkadot-api/issues/760`);
+            throw new Error(`txOpts not supported for unsigned transactions`);
        }
+        // With #[pallet::authorize], unsigned transactions must be submitted as "general"


@antkve very good job, here, I am trying to push this for PAPI: polkadot-api/polkadot-api#760 (comment)

bkontur · 2026-03-26T16:11:55Z

Let's keep this open and figure out the PAPI support: https://matrix.to/#/!bMWYTUFeSoYacMOlpS:matrix.parity.io/$pqN2BJJpI8gAoEziYDuVXF-j6dt0FMlIW_wP9SgXfTU?via=parity.io&via=matrix.org&via=matrix.parity.io

bkontur · 2026-03-26T16:21:38Z

Let's keep this open and figure out the PAPI support: https://matrix.to/#/!bMWYTUFeSoYacMOlpS:matrix.parity.io/$pqN2BJJpI8gAoEziYDuVXF-j6dt0FMlIW_wP9SgXfTU?via=parity.io&via=matrix.org&via=matrix.parity.io

@antkve actually, there should be some hacky workaround: polkadot-js/api#6213 (comment) or maybe:

let general_signer = getPolkadotSigner(
    (data: Uint8Array) => alice.sign(data)
);

bkontur · 2026-03-26T16:37:53Z

@antkve let's keep our stuff for now, but could you just try this: polkadot-api/polkadot-api#760 (comment)?

cla-bot-2021 · 2026-05-07T21:44:55Z

User @claude, please sign the CLA here.

antkve force-pushed the ak-validate-unsigned branch 2 times, most recently from e7af58e to 42a690a Compare January 22, 2026 13:37

bkontur reviewed Jan 22, 2026

View reviewed changes

bkontur mentioned this pull request Jan 25, 2026

Define audit scope + document basic functionality #31

Open

12 tasks

antkve force-pushed the ak-validate-unsigned branch from 006ed23 to 111cb5e Compare February 11, 2026 12:56

antkve and others added 18 commits February 12, 2026 17:02

Removed deprecated ValidateUnsigned

8e3e520

Fixed name

aa5574a

Removed auth contexts and simplified

0c7c14b

Fixed preimage test to reflect consume-at-dispatch

1c022bd

Format

8f2e817

Clippy fix

ca6dd6e

Added preimage test

42d021f

Moved preimage test to subxt

e1cd9f5

Fixed merge

5de03b6

Fixed merge again

a785122

Format

6ac2154

Fixed duplicate just

27d797d

Fix test + verify preimage data

a6549f4

Fix compilation

6e5751d

Format yet again

c5edd6f

Test fix

d889e16

Fixed compilation

8272287

fix: feeless_if

15c767d

franciscoaguirre force-pushed the ak-validate-unsigned branch from 7939ab8 to 15c767d Compare February 13, 2026 00:43

Merge branch 'main' into ak-validate-unsigned

df3382f

Fixed integration test

a328ebd

antkve and others added 4 commits February 13, 2026 19:00

Benchmark fix?

18970e2

Format

45f7951

Merge branch 'main' into ak-validate-unsigned-2

1de7bb1

bkontur reviewed Feb 17, 2026

View reviewed changes

bkontur mentioned this pull request Feb 23, 2026

Improvments to runtime configuration #265

Merged

antkve and others added 5 commits March 24, 2026 23:31

Merge branch 'main' into ak-validate-unsigned

304758d

Cleaned up and removed providecidconfig from tests

12644e5

General tx with papi

a92f6e1

Fixed test

655bc31

Merge branch 'main' into ak-validate-unsigned

36e437c

bkontur reviewed Mar 26, 2026

View reviewed changes

bkontur marked this pull request as ready for review March 26, 2026 16:11

Updated general TX script to recommended generalSigner syntax

723db18

bkontur mentioned this pull request Mar 30, 2026

Deprecate ValidateUnsigned trait and #[pallet::validate_unsigned] attribute paritytech/polkadot-sdk#10150

Merged

12 tasks

	Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::Validate),
	Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::PreDispatch),

Conversation

antkve commented Jan 21, 2026 • edited by bkontur Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

bkontur commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antkve commented Jan 22, 2026

Uh oh!

bkontur Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

bkontur commented Jan 22, 2026

Uh oh!

franciscoaguirre commented Feb 13, 2026

Uh oh!

bkontur Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

antkve Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

bkontur commented Feb 19, 2026

Uh oh!

bkontur commented Mar 4, 2026

Uh oh!

bkontur commented Mar 19, 2026

Uh oh!

bkontur Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

bkontur commented Mar 26, 2026

Uh oh!

bkontur commented Mar 26, 2026

Uh oh!

bkontur commented Mar 26, 2026

Uh oh!

cla-bot-2021 Bot commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

antkve commented Jan 21, 2026 •

edited by bkontur

Loading

bkontur commented Jan 22, 2026 •

edited

Loading