Align Types between Bulletin and SDK

[raymondkfcheung]

Addresses #86

[raymondkfcheung]

@bkontur Shall we use #[pallet::storage] like on the SDK repo or keep as #[pallet::constant]?

[bkontur]

@bkontur Shall we use #[pallet::storage] like on the SDK repo or keep as #[pallet::constant]?

hmm, good question, I don't know now, what we use at the end, it is kind of sensible constant, depends on pruning and renewal stuff, but want to have this as a configurable. We will later need to read this by custom inherent provider with runtime api.

So it does not matter if it is storage or const. Hmm, let's keep polkadot-sdk as storage and bulletin as constant for now, when we come to the provider, we will decide

[raymondkfcheung]

Yes, I agree. We can keep them as they are for now if there’s a difference between the two repos.

There is one tricky bit though: I think StoragePeriod may need to switch to #[pallet::storage]. In the SDK it’s initialised in genesis_build:

https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/transaction-storage/src/lib.rs#L429

ByteFee::<T>::put(&self.byte_fee);
EntryFee::<T>::put(&self.entry_fee);
StoragePeriod::<T>::put(&self.storage_period);

[raymondkfcheung]

For StoragePeriod, I’ll follow up on this in a separate PR.

[bkontur]

@raymondkfcheung just out of curiosity, why this change?

[raymondkfcheung]

The test/mock files were failed to compile.

[bkontur]

strange, because there is one more below:

impl<AccountId, HoldReason> Currency<AccountId> for NoCurrency<AccountId, HoldReason> {
	type Balance = u128;

[raymondkfcheung]

Reverted and it works now.