Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Remove debian/.deb and centos/.rpm packaging scripts#8887

Merged
5chdn merged 9 commits into
masterfrom
a5-ci-packages
Jun 18, 2018
Merged

Remove debian/.deb and centos/.rpm packaging scripts#8887
5chdn merged 9 commits into
masterfrom
a5-ci-packages

Conversation

@5chdn
Copy link
Copy Markdown
Contributor

@5chdn 5chdn commented Jun 13, 2018 •
edited
Loading

After #8875 and finalizing #8649

  • remove centos pipeline and remove rpm packaging
  • remove debian pipeline and remove deb packaging
  • rename ubuntu pipelines to generic linux and only build binaries, no packaging
  • remove all unused libssl dependencies
  • init git submodules in test suite
  • do not publish every build from master, only from nightly tag

Test pipeline: https://gitlab.parity.io/parity/parity/pipelines/20791 ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ ✔️ 🤣

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M5-binaries 📦 External binaries (ethkey, ethstore, ethvm, etc.) M1-ci 🙉 Continuous integration. labels Jun 13, 2018
@5chdn 5chdn added this to the 1.12 milestone Jun 13, 2018
@5chdn 5chdn requested a review from ascjones June 13, 2018 12:28
@5chdn 5chdn mentioned this pull request Jun 13, 2018
Closed
ascjones
ascjones approved these changes Jun 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleticious

debris
debris approved these changes Jun 14, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @paritytech/ci can you also review?

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 14, 2018
@General-Beck
Copy link
Copy Markdown
Contributor

General-Beck commented Jun 16, 2018

I install packages in accordance with the standards of distributions. We do not have our own distribution system. Why do we remove all this now until we accept the new format of the CI system?

@General-Beck General-Beck added the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Jun 16, 2018
@5chdn 5chdn removed the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Jun 18, 2018
@5chdn 5chdn merged commit c9cee8f into master Jun 18, 2018
@5chdn 5chdn deleted the a5-ci-packages branch June 18, 2018 09:49
@5chdn
Copy link
Copy Markdown
Contributor Author

5chdn commented Jun 18, 2018

@General-Beck #8765 is stale for 2+ weeks now waiting for several issues to be addressed. I can not afford to delay any progress here. I'm sorry if this conflicts with your work, but for now, I need a working solution.

We plan not to maintain any installers or distribution packages anymore. This is up to the system's maintainers and communities. We build and maintain the core technology and that's it. Happy to keep snapcraft, docker, and homebrew alive though (unless there are major annoyances).

dvdplm added a commit that referenced this pull request Jun 18, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
1d7dc83 
* master:
  Hardware-wallets `Clean up things I missed in the latest PR` (#8890)
  Remove debian/.deb and centos/.rpm packaging scripts (#8887)
  Remove a weird emoji in new_social docs (#8913)
ordian added a commit to ordian/parity that referenced this pull request Jun 20, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
dc3ec66 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Include node identity in the P2P advertised client version. (openethereum#8830)
  Allow disabling local-by-default for transactions with new config entry (openethereum#8882)
  Allow Poll Lifetime to be configured via CLI (openethereum#8885)
  cleanup nibbleslice (openethereum#8915)
  Hardware-wallets `Clean up things I missed in the latest PR` (openethereum#8890)
  Remove debian/.deb and centos/.rpm packaging scripts (openethereum#8887)
  Remove a weird emoji in new_social docs (openethereum#8913)
  Minor fix in chain supplier and light provider (openethereum#8906)
@Tbaut Tbaut mentioned this pull request Jul 13, 2018
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ascjones ascjones ascjones approved these changes

@debris debris debris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration. M5-binaries 📦 External binaries (ethkey, ethstore, ethvm, etc.)

Projects

None yet

Milestone

2.0 Ethereum

Development

Successfully merging this pull request may close these issues.

4 participants

@5chdn @General-Beck @ascjones @debris