Hardware-wallets Clean up things I missed in the latest PR#8890
Conversation
niklasad1
added
A0-pleasereview 🤓
niklasad1
force-pushed
the
na-clean-up-hardware-wallets
branch
from
ca2ba60 to
a160a2e
Compare
|
lol did I merge too fast? |
|
No, I didn’t want to introduce new changes after it got approved ;) |
| pub enum DeviceDirection { | ||
| Arrived, | ||
| Left, | ||
| /// Device arrived |
There was a problem hiding this comment.
As in "user pulled out the wallet from the usb port"? Maybe be explicit here and say Device became available/Device was removed from the system?
There was a problem hiding this comment.
@dvdplm do you want s/Arrived/Available/ s/Left/Unavailable renamed completely including the enum patterns?
Happy to change, I have no strong opinions here!
There was a problem hiding this comment.
I think that would make sense, yes, but my grumble was about the doc-comment. :)
There was a problem hiding this comment.
Ok, I having second thoughts on this because DeviceDirection doesn't actually indicate whether a device became available or unavailable. Essentially, it only tells we got a notification that a USB device was connected or disconnected with manufacturer ID (Ledger or Trezor). To actually say that a device become available/unavailable we need to do additional checks, for instance, request an Ethereum address and so on!
So, I will keep this! Ok?!
|
|
||
| // Try to connect to the device using polling in at most the time specified by the `timeout` | ||
| fn try_connect_polling(ledger: Arc<Manager>, timeout: &Duration, device_direction: DeviceDirection) -> bool { | ||
| fn try_connect_polling(ledger: &Arc<Manager>, timeout: &Duration, device_direction: DeviceDirection) -> bool { |
There was a problem hiding this comment.
maybe just &Manager? &Arc<Manager> will be automatically dereferenced to it
There was a problem hiding this comment.
Goood catch thanks 🥇
debris
added
A8-looksgood 🦄
|
Do you mind merging master into this or rebasing? Makes it easier to review (also avoids having repeated commits in the changelog). |
niklasad1
force-pushed
the
na-clean-up-hardware-wallets
branch
2 times, most recently
from
6f74865 to
c8f2037
Compare
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
LGTM, just a small nit regarding &Arc<Manager>.
|
|
||
| // Try to connect to the device using polling in at most the time specified by the `timeout` | ||
| fn try_connect_polling(trezor: Arc<Manager>, duration: &Duration, dir: DeviceDirection) -> bool { | ||
| fn try_connect_polling(trezor: &Arc<Manager>, duration: &Duration, dir: DeviceDirection) -> bool { |
|
|
||
| //! Ledger hardware wallet module. Supports Ledger Blue and Nano S. | ||
| /// See https://github.com/LedgerHQ/blue-app-eth/blob/master/doc/ethapp.asc for protocol details. | ||
| /// See <https://github.com/LedgerHQ/blue-app-eth/blob/master/doc/ethapp.asc> for protocol details. |
There was a problem hiding this comment.
Maybe replace "///" with "//!".
andresilva
added
A5-grumble 🔥
* &Arc<Manager> -> &Manager * Rustdoc -> Crate doc
niklasad1
force-pushed
the
na-clean-up-hardware-wallets
branch
from
c8f2037 to
a194156
Compare
debris
added
A8-looksgood 🦄
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: Include node identity in the P2P advertised client version. (openethereum#8830) Allow disabling local-by-default for transactions with new config entry (openethereum#8882) Allow Poll Lifetime to be configured via CLI (openethereum#8885) cleanup nibbleslice (openethereum#8915) Hardware-wallets `Clean up things I missed in the latest PR` (openethereum#8890) Remove debian/.deb and centos/.rpm packaging scripts (openethereum#8887) Remove a weird emoji in new_social docs (openethereum#8913) Minor fix in chain supplier and light provider (openethereum#8906)
5 participants
No description provided.