Fix transitive local path propagation for --registry flag#72
Closed
Fix transitive local path propagation for --registry flag#72
Conversation
When apply --registry rewrites dependencies, crates not on crates.io use local paths while existing versions use registry. This creates inconsistent graphs: if crate A is bumped (not on crates.io) but dependent B exists on registry, the registry B pulls old A, causing duplicate versions and trait bound errors. Now computes transitive closure of crates requiring local paths before rewriting, ensuring dependents of local-only crates also use local paths.
Author
|
See related SDK tentative PR: paritytech/polkadot-sdk#10905 |
Author
|
The main question @iulianbarbu @bkchr is if in a scenario like the one described in this PR, we want to actually fail so the current behavior is correct or if we want to propagate local path to all deps of a not published crate |
Contributor
|
My opinion is that what you did here: paritytech/polkadot-sdk#10905 is the correct fix for the situation you found yourself in. Doing this fix will hide missing bumps I think, which are relevant before trying to do a certain release that captures all the updates for all the crates. |
Author
|
Hey @iulianbarbu - I agree with you, this change would just make the CI job happy hiding the truth for release team (cc @EgorPopelyaev ) so I'll drop it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When apply --registry rewrites dependencies, crates not on crates.io use local paths while existing versions use registry. This creates inconsistent graphs: if crate A is bumped (not on crates.io) but dependent B exists on registry, the registry B pulls old A, causing duplicate versions and trait bound errors.
Now computes transitive closure of crates requiring local paths before rewriting, ensuring dependents of local-only crates also use local paths.