This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Remove unused event variants and fields from Issue Events #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-paulo-parity
force-pushed
the
update_variants
branch
from
151cfc2 to
bf49fdd
Compare
ordian
reviewed
Mar 9, 2021
ordian
reviewed
Mar 9, 2021
ordian
reviewed
Mar 9, 2021
joao-paulo-parity
force-pushed
the
update_variants
branch
from
bf49fdd to
7e55082
Compare
joao-paulo-parity
force-pushed
the
update_variants
branch
from
7e55082 to
2939dd0
Compare
joao-paulo-parity
added a commit
that referenced
this pull request
Mar 10, 2021
use serde(other) to avoid parsing errors on unused variants suggested in #244 (comment)
joao-paulo-parity
force-pushed
the
update_variants
branch
from
2939dd0 to
8e946b6
Compare
ordian
approved these changes
Mar 10, 2021
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
It's strange that we only use two event types and two fields, but if the code compiles, then it's fine.
In the future we might also want to keep track of Closed, Merged and Reopened and probably other variants.
use serde(other) to avoid parsing errors on unused variants suggested in #244 (comment)
joao-paulo-parity
force-pushed
the
update_variants
branch
from
4f0ea81 to
b6617b5
Compare
haikoschol
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #219
Takes the suggestion from #219 (comment) to trim down to the used variants only. It's quite likely more code can be removed throughout the project, but that's part of another issue (#243).
Initially, the approach was parsing the field as
Stringand then matching them through an interface (#245); that approach was removed in favor of another suggestion (#244 (comment)).