Skip to content

github actions ci #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ordian merged 21 commits into from
Jul 1, 2021
Merged

github actions ci #559

ordian merged 21 commits into from
Jul 1, 2021

Conversation

@ordian
Copy link
Contributor

@ordian ordian commented Jun 30, 2021 •
edited
Loading

Fixes #555.

Doesn't include tests for kvdb-web, I'm planning to decommission it soon.

  • update readme badge
  • test parity-util-mem allocators

@ordian ordian requested a review from TriplEight June 30, 2021 17:08
@ordian ordian mentioned this pull request Jul 1, 2021
Merged
@ordian ordian requested review from dvdplm and niklasad1 July 1, 2021 14:01
niklasad1
niklasad1 reviewed Jul 1, 2021
View reviewed changes
niklasad1
niklasad1 reviewed Jul 1, 2021
View reviewed changes
TriplEight
TriplEight approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything's hunky-dory!

TriplEight
TriplEight reviewed Jul 1, 2021
View reviewed changes
@TriplEight
Copy link
Contributor

TriplEight commented Jul 1, 2021

I do not know how loaded this project is, so please tell me if these pipelines are taking too much time for your taste, then we'll rewrite some parts on GitLab, it would be a way faster.

@ordian
Copy link
Contributor Author

ordian commented Jul 1, 2021

I do not know how loaded this project is, so please tell me if these pipelines are taking too much time for your taste, then we'll rewrite some parts on GitLab, it would be a way faster.

It's quite slow w/o a cache, up to 30 mins, but we can live with that for now and hopefully cache will help as well.

@TriplEight
Copy link
Contributor

TriplEight commented Jul 1, 2021

It's quite slow w/o a cache, up to 30 mins, but we can live with that for now and hopefully cache will help as well.

It will definitely help.
But there's a limit of 5Gb of cache per project and if it's more than that, that's a sign to move to GitLab CI.

@ordian @TriplEight
cache cargo check
ca803cc 
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
@ordian ordian merged commit 9e0e53a into master Jul 1, 2021
@ordian ordian deleted the ao-ci branch July 1, 2021 15:24
@TriplEight
Copy link
Contributor

TriplEight commented Jul 2, 2021

image

This looks a way better than this:

image

@Xanewok Xanewok mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@niklasad1 niklasad1 niklasad1 left review comments

@TriplEight TriplEight TriplEight approved these changes

@dvdplm dvdplm dvdplm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: migrate to github actions

5 participants

@ordian @TriplEight @dvdplm @niklasad1