Skip to content

ethereum-types: fix wasm builds for serialize feature #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ordian merged 7 commits into from
Jan 20, 2021
Merged

ethereum-types: fix wasm builds for serialize feature #503

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b86b821
ethbloom: do not pull std for 'serialize' feature
ordian Jan 12, 2021
adc8f8a
ethereum-types: do not pull std for 'serialize' feature
ordian Jan 12, 2021
b5bc32c
CI: check wasm builds for ethbloom and ethereum-types
ordian Jan 12, 2021
30c3c3d
fix wasm target
ordian Jan 12, 2021
64557a7
CI: remove redundant check
ordian Jan 12, 2021
646342a
CI: fix wasm target install
ordian Jan 12, 2021
3b8dcb5
update changelogs
ordian Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ matrix:
allow_failures:
- rust: nightly
install:
- rustup target add wasm32-unknown-unknown
- curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | sh
- source ~/.nvm/nvm.sh
- nvm install --lts
Expand All @@ -42,6 +43,7 @@ script:
cd contract-address/ && cargo test --features=external_doc && cd ..;
fi
- cd ethbloom/ && cargo test --no-default-features --features="rustc-hex" && cargo check --benches && cd ..
- cd ethereum-types/ && cargo build --no-default-features --features="serialize,rlp" --target=wasm32-unknown-unknown && cd ..
- cd fixed-hash/ && cargo test --all-features && cargo test --no-default-features --features="byteorder,rustc-hex" && cd ..
- cd uint/ && cargo test --all-features && cargo test --no-default-features && cd ..
- cd keccak-hash/ && cargo test --no-default-features && cd ..
Expand Down
2 changes: 1 addition & 1 deletion ethbloom/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ hex-literal = "0.3.1"
[features]
default = ["std", "rlp", "serialize", "rustc-hex"]
std = ["fixed-hash/std", "crunchy/std"]
serialize = ["std", "impl-serde"]
serialize = ["impl-serde"]
rustc-hex = ["fixed-hash/rustc-hex"]
arbitrary = ["fixed-hash/arbitrary"]
rlp = ["impl-rlp"]
Expand Down
2 changes: 1 addition & 1 deletion ethereum-types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ serde_json = "1.0.41"
[features]
default = ["std", "rlp", "serialize"]
std = ["uint-crate/std", "fixed-hash/std", "ethbloom/std", "primitive-types/std"]
serialize = ["std", "impl-serde", "primitive-types/serde", "ethbloom/serialize"]
serialize = ["impl-serde", "primitive-types/serde_no_std", "ethbloom/serialize"]
arbitrary = ["ethbloom/arbitrary", "fixed-hash/arbitrary", "uint-crate/arbitrary"]
rlp = ["impl-rlp", "ethbloom/rlp", "primitive-types/rlp"]
codec = ["impl-codec", "ethbloom/codec"]
Expand Down