Add Rocksdb Secondary Instance Api#384
Merged
Merged
Conversation
This reverts commit ace87ee.
* master: Fix limit prefix delete case (paritytech#368) Add arbitrary trait implementation (paritytech#378)
This comment has been minimized.
This comment has been minimized.
ordian
reviewed
Apr 28, 2020
ordian
reviewed
Apr 28, 2020
Co-Authored-By: Andronik Ordian <write@reusable.software>
dvdplm
reviewed
Apr 29, 2020
Co-Authored-By: David <dvdplm@gmail.com>
Co-Authored-By: David <dvdplm@gmail.com>
Co-Authored-By: David <dvdplm@gmail.com>
dvdplm
reviewed
Apr 30, 2020
dvdplm
reviewed
Apr 30, 2020
ordian
reviewed
Apr 30, 2020
ordian
reviewed
Apr 30, 2020
Co-authored-by: Andronik Ordian <write@reusable.software>
ordian
approved these changes
Apr 30, 2020
Contributor
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Looks good modulo unresolved comments.
Contributor
Author
|
Yeah still investigating how exactly Rocksdb handles secondary connections, but should be resolved sometime today |
expand on what `try_catch_up_with_secondary` does, since it may have some implications on the primary instance of rocksdb according to L503-566 in `db/db_impl/db_impl_secondary.cc` of facebook/rocksdb
insipx
changed the title
ordian
reviewed
May 1, 2020
ordian
added a commit
that referenced
this pull request
May 5, 2020
* master: (56 commits) primitive-types: add no_std support for serde feature (#385) Add Rocksdb Secondary Instance Api (#384) kvdb-rocksdb: update rocksdb to 0.14 (#379) prepare releases for a few crates (#382) uint: fix UB in uint::from_big_endian (#381) Fix limit prefix delete case (#368) Add arbitrary trait implementation (#378) kvdb-rocksdb: optimize and rename iter_from_prefix (#365) bump parity-util-mem (#376) parity-util-mem: fix for windows (#375) keccak-hash: fix bench and add one for range (#372) [parity-crypto] Release 0.6.1 (#373) keccak-hash: bump version to 0.5.1 (#371) keccak-hash: add keccak256_range and keccak512_range functions (#370) Allow pubkey recovery for all-zero messages (#369) Delete by prefix operator in kvdb (#360) kvdb: no overlay (#313) Ban duplicates of parity-uil-mem from being linked into the same program (#363) Use correct license ID (#362) Memtest example for Rocksdb (#349) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds rocksdb
open_as_secondaryapi added inrust-rocksdb0.14 to the paritykvdb-rocksdbcrateuseful for reading from rocksdb while a node is running
blocked on #379Secondary API RocksDB Docs: https://github.com/facebook/rocksdb/wiki/Secondary-instance