Prep for release#361
Merged
Merged
Conversation
ordian
reviewed
Mar 16, 2020
dvdplm
commented
Mar 16, 2020
| [package] | ||
| name = "ethereum-types" | ||
| version = "0.8.0" | ||
| version = "0.8.1" |
Contributor
Author
There was a problem hiding this comment.
@ordian are you saying this must be 0.9 too?
Contributor
There was a problem hiding this comment.
yes, because it exposes fixed_hash::H256 from 0.6 instead of fixed_hash::H256 from 0.5
ordian
reviewed
Mar 16, 2020
| [package] | ||
| name = "keccak-hash" | ||
| version = "0.4.1" | ||
| version = "0.4.2" |
Contributor
Author
There was a problem hiding this comment.
I will obey, but are you sure that features available in keccak-hash used the libc feature from primitive-types in the past?
Contributor
There was a problem hiding this comment.
it's not about features anymore, once you expose a type in a lib
parity-common/keccak-hash/src/lib.rs
Line 35 in bf58794
and upgrade a dependency with that type in a semver breaking way, the breakage speads like a virus into the lib
ordian
reviewed
Mar 16, 2020
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
ordian
approved these changes
Mar 16, 2020
gnunicorn
approved these changes
Mar 16, 2020
ordian
added a commit
that referenced
this pull request
Mar 26, 2020
ordian
added a commit
that referenced
this pull request
Apr 22, 2020
* master: kvdb-rocksdb: optimize and rename iter_from_prefix (#365) bump parity-util-mem (#376) parity-util-mem: fix for windows (#375) keccak-hash: fix bench and add one for range (#372) [parity-crypto] Release 0.6.1 (#373) keccak-hash: bump version to 0.5.1 (#371) keccak-hash: add keccak256_range and keccak512_range functions (#370) Allow pubkey recovery for all-zero messages (#369) Delete by prefix operator in kvdb (#360) kvdb: no overlay (#313) Ban duplicates of parity-uil-mem from being linked into the same program (#363) Use correct license ID (#362) Memtest example for Rocksdb (#349) Prep for release (#361) parity-util-mem: prepare release for 0.5.2 (#359) travis: test parity-util-mem on android (#358) parity-util-mem: update mimalloc feature (#352) kvdb: remove parity-bytes dependency (#351) parity-util-mem: use malloc for usable_size on android (#355) CI: troubleshoot macOS build (#356)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.