Skip to content

kvdb: remove parity-bytes dependency #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niklasad1 merged 4 commits into from
Mar 13, 2020
Merged

kvdb: remove parity-bytes dependency #351

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec39e6b
kvdb: remove parity-bytes dependency
ordian Mar 11, 2020
46b1866
kvdb: update changelog
ordian Mar 11, 2020
74770eb
Merge branch 'master' into ao-kvdb-remove-unused-dependency
ordian Mar 12, 2020
f116eae
Update kvdb/CHANGELOG.md
ordian Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kvdb/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog].

## [Unreleased]
- License changed from GPL3 to dual MIT/Apache2. [#342](https://github.com/paritytech/parity-common/pull/342)
- Remove dependency on parity-bytes. [#351](https://github.com/paritytech/parity-common/pull/351)
Comment thread
ordian marked this conversation as resolved.
Outdated

## [0.4.0] - 2019-01-06
- Bump parking_lot to 0.10. [#332](https://github.com/paritytech/parity-common/pull/332)
Expand Down
1 change: 0 additions & 1 deletion kvdb/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ edition = "2018"

[dependencies]
smallvec = "1.0.0"
bytes = { package = "parity-bytes", version = "0.1", path = "../parity-bytes" }
parity-util-mem = { path = "../parity-util-mem", version = "0.5", default-features = false }
3 changes: 1 addition & 2 deletions kvdb/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

//! Key-Value store abstraction.

use bytes::Bytes;
use smallvec::SmallVec;
use std::io;

Expand Down Expand Up @@ -73,7 +72,7 @@ impl DBTransaction {
}

/// Insert a key-value pair in the transaction. Any existing value will be overwritten upon write.
pub fn put_vec(&mut self, col: u32, key: &[u8], value: Bytes) {
pub fn put_vec(&mut self, col: u32, key: &[u8], value: Vec<u8>) {
self.ops.push(DBOp::Insert { col, key: DBKey::from_slice(key), value });
}

Expand Down