Skip to content

Implement Error for FromDecStrErr#346

Merged
ordian merged 2 commits into
paritytech:masterfrom
e00E:master
Feb 21, 2020
Merged

Implement Error for FromDecStrErr#346
ordian merged 2 commits into
paritytech:masterfrom
e00E:master

Conversation

@e00E
Copy link
Copy Markdown
Contributor

@e00E e00E commented Feb 21, 2020

No description provided.

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Feb 21, 2020

It looks like @e00E hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@e00E
Copy link
Copy Markdown
Contributor Author

e00E commented Feb 21, 2020

[clabot:check]

@parity-cla-bot
Copy link
Copy Markdown

parity-cla-bot commented Feb 21, 2020

It looks like @e00E signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

ordian
ordian reviewed Feb 21, 2020
View reviewed changes
Comment thread uint/src/uint.rs
InvalidLength,
}

impl std::fmt::Display for FromDecStrErr {
Copy link
Copy Markdown
Contributor

@ordian ordian Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI failure is legit, we should hide this (and the one below) impl under cfg(feature = std)

parity-common/uint/src/uint.rs

Line 1546 in 46d8f6b

macro_rules! impl_std_for_uint {

@ordian ordian merged commit 05d7da8 into paritytech:master Feb 21, 2020
ordian added a commit that referenced this pull request Mar 2, 2020
@ordian
Merge branch 'master' into ao-no-overlay
20a62a4 
* master:
  kvdb-rocksdb: bump version (#348)
  kvdb-rocksdb: expose RocksDB stats (#347)
  Implement Error for FromDecStrErr (#346)
  Fix clippy lints for rlp-derive (#345)
ordian added a commit that referenced this pull request Mar 6, 2020
@ordian
Merge branch 'master' into ao-kvdb-sled
96745ec 
* master:
  kvdb-rocksdb: bump version (#348)
  kvdb-rocksdb: expose RocksDB stats (#347)
  Implement Error for FromDecStrErr (#346)
  Fix clippy lints for rlp-derive (#345)
  prepare rlp-derive release (#344)
  Update/change licenses: MIT/Apache2.0 (#342)
  rlp-derive extracted (#343)
  Format for readme and changelog corrected (#341)
  Parity runtime moved to parity common for publication in crates.io (#271)
  Disable cache if explicit memory budget=0 passed (#339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ordian ordian ordian approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@e00E @parity-cla-bot @tomusdrw @ordian