Skip to content

Conversation

@NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Aug 22, 2018

(overflowing_div/overflowing_rem is pointless for unsigned integers)

@NikVolf NikVolf changed the title Remove outdated comments and switches Fix docs, remove outdated comments, remove overflowing divs/rems. Aug 22, 2018
@sorpaas
Copy link
Contributor

sorpaas commented Sep 4, 2018

Not yet sure whether this is a good idea or not, but I just want to note that Rust's primitive type like u64 do have overflowing_div and overflowing_rem. Would we want to consider to add them still as helper functions, just so that, quoting Rust's docs, "all operations are accounted for in the overflowing operations"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants