Fix impl-serde::serializa/_raw for empty slices#253
Conversation
|
This is really frustrating. What happened to the entire suite of tests for this stuff? Was it not ported from the ethereum codebase? |
|
We have some tests in https://github.com/paritytech/parity-common/blob/master/ethereum-types/tests/serde.rs. I think it was ported from https://github.com/paritytech/primitives/, don't see any additional tests there. |
|
@tomusdrw The serde tests for ethereum-types were ported to this repo but I'm not sure how the tests differ. As I said before, EDIT: |
|
It's been a while but I don't think there were serde tests in |
|
Indeed seems that tests for |
Fixes: paritytech/substrate#3946