Skip to content

Fix impl-serde::serializa/_raw for empty slices#253

Merged
ordian merged 1 commit into
masterfrom
bkchr-fix-empty-serialize
Oct 29, 2019
Merged

Fix impl-serde::serializa/_raw for empty slices#253
ordian merged 1 commit into
masterfrom
bkchr-fix-empty-serialize

Conversation

@bkchr
Copy link
Copy Markdown
Member

@bkchr bkchr commented Oct 29, 2019

@tomusdrw
Copy link
Copy Markdown
Contributor

tomusdrw commented Oct 29, 2019

This is really frustrating. What happened to the entire suite of tests for this stuff? Was it not ported from the ethereum codebase?

@ordian
Copy link
Copy Markdown
Contributor

ordian commented Oct 29, 2019

@ordian ordian merged commit c3e8d85 into master Oct 29, 2019
@ordian ordian deleted the bkchr-fix-empty-serialize branch October 29, 2019 14:29
ordian added a commit that referenced this pull request Oct 29, 2019
* master:
  impl-serde: bump to 0.2.3
  Fix `impl-serde::serializa/_raw` for empty slices (#253)
  Release impl-rlp 0.2.1 (#250)
@niklasad1
Copy link
Copy Markdown
Contributor

niklasad1 commented Oct 29, 2019

@tomusdrw The serde tests for ethereum-types were ported to this repo but I'm not sure how the tests differ.

As I said before, ethereum doesn't use serialize/deserialize Bytes from this repo so definitely not ported from ethereum but we should merge them ideally

EDIT: ethereum Bytes is using rustc::ToHex which was probably removed because of more allocations were required but I wasn't involved so I don't remember

@dvdplm
Copy link
Copy Markdown
Contributor

dvdplm commented Oct 29, 2019

It's been a while but I don't think there were serde tests in primitives, or only very basic.

@tomusdrw
Copy link
Copy Markdown
Contributor

Indeed seems that tests for Bytes were missing, good that we are now getting some :)

ordian added a commit that referenced this pull request Oct 29, 2019
* master:
  Fix `impl-serde::serializa/_raw` for empty slices (#253)
  Release impl-rlp 0.2.1 (#250)
  export FromDecStrErr (#244)
  Upgrade dependencies (#239)
ordian added a commit that referenced this pull request Nov 10, 2019
* master:
  add CONTRIBUTING guidelines and initial changelogs (#249)
  impl-serde: bump to 0.2.3 (#254)
  Fix `impl-serde::serializa/_raw` for empty slices (#253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serde serialization of empty StorageKey panics

5 participants