Upgrade depenencies#236
Conversation
|
It looks like @demimarie-parity hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
Demi-Marie
force-pushed
the
upgrade-deps
branch
from
a64cd40 to
6b64319
Compare
Demi-Marie
force-pushed
the
upgrade-deps
branch
from
6b64319 to
f4008ad
Compare
|
A lot of funny looking lifetime annotations appeared here, why is that? And while explicit versions down to the patch level is fine I am not sure they are strictly needed, can you elaborate a bit on what motivates these changes? |
|
@dvdplm I think it fixes a lint/warning part of the |
| } | ||
|
|
||
| /// Create a new hash with cryptographically random content. | ||
| pub fn random() -> Self { |
There was a problem hiding this comment.
why remove? It is a breaking change
There was a problem hiding this comment.
rustc warned about it being unused.
There was a problem hiding this comment.
How can cargo fix know that a pub item is not used?
|
|
||
|
|
||
| extern crate parity_crypto; | ||
| use parity_crypto; |
There was a problem hiding this comment.
Agreed. This was done automatically.
| #[cfg(test)] | ||
| mod tests { | ||
| extern crate tempdir; | ||
| use tempdir; |
There was a problem hiding this comment.
Not required.
Just remove the use self::tempdir below and just use tempdir::
There was a problem hiding this comment.
It is indeed not required. The changes to the Rust code were done automatically by cargo fix.
The lifetime annotations were generated by |
5 participants
No description provided.