[fixed-hash] Migrated code to the 2018 edition and updated dependencies#223
Merged
Conversation
added 2 commits
September 22, 2019 20:26
|
It looks like @expenses signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ordian
reviewed
Sep 22, 2019
added 2 commits
September 22, 2019 21:00
This reverts commit 57ae6b5.
dvdplm
reviewed
Sep 22, 2019
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
lgtm overall but tests fail
ordian
reviewed
Sep 22, 2019
Co-Authored-By: Andronik Ordian <write@reusable.software>
Contributor
|
Needs resolving (and please revert dependencies upgrade as it's a breaking change) |
ordian
approved these changes
Oct 7, 2019
| quickcheck = { version = "0.9", optional = true } | ||
| byteorder = { version = "1.2", optional = true, default-features = false } | ||
| static_assertions = "0.2" | ||
| static_assertions = "0.3" |
Contributor
There was a problem hiding this comment.
I think this is a technically a breaking change, since we pub use these crates. But I doubt someone will get an error because of that.
Contributor
There was a problem hiding this comment.
yupp, the same applies to quickcheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #143.