[parity-util-mem] remove Memzero#183
Merged
Merged
Conversation
dvdplm
approved these changes
Jun 28, 2019
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Sure, why not. Are you taking care of the the fallout of this too?
Contributor
Author
I'll prepare a PR to parity-ethereum and parity-crypto. |
This was referenced Jun 28, 2019
ordian
added a commit
that referenced
this pull request
Jul 4, 2019
* master: [parity-util-mem] remove Memzero (#183)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181. This is a breaking change.
We could probably reexport zeroize's
ZeroizingasMemzero, but I don't see any benefits of that. Also I'm in favor of Single Responsibility Principle and if a crate wants to (only) usezeroizefunctionality, it doesn't have to depend on allocator stuff.