Implemented TryFrom<biguint> for primitives#148
Merged
Conversation
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ordian
approved these changes
May 13, 2019
Contributor
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just one small suggestion.
dvdplm
reviewed
May 13, 2019
dvdplm
approved these changes
May 15, 2019
Contributor
|
published 0.7.1 |
ordian
added a commit
to ordian/parity-common
that referenced
this pull request
May 16, 2019
* paritytech/master: [parity-bytes] add no-std support (paritytech#154) [parity-crypto] Derive Debug for digests and signatures (paritytech#155) Restore the previous API to allow variable size keys for Hmac operations (paritytech#152) Implemented TryFrom<biguint> for primitives (paritytech#148)
dvdplm
added a commit
that referenced
this pull request
May 19, 2019
* master: [parity-crypto] zero memory for hmac signing keys (#157) Added absolute path for 'Result' usage in macros to avoid type collisions. (#160) [parity-bytes] add no-std support (#154) [parity-crypto] Derive Debug for digests and signatures (#155) Restore the previous API to allow variable size keys for Hmac operations (#152) Implemented TryFrom<biguint> for primitives (#148)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
With
TryFromimplementation, users could try conversion from big uint types to primitive uint types. Such as:u128::try_from(U256([0, 1, 0, 0]))U256([0, 0, 1, 0]).try_into().unwrap_or(u128::max_value())