Skip to content

Revert 9077#11

Merged
dvdplm merged 2 commits into
paritytech:masterfrom
tomaka:revert-9077
Jul 12, 2018
Merged

Revert 9077#11
dvdplm merged 2 commits into
paritytech:masterfrom
tomaka:revert-9077

Conversation

@tomaka
Copy link
Copy Markdown
Contributor

@tomaka tomaka commented Jul 11, 2018

This reverts commit da70a78.

Fixes the Android build.

@tomaka
Copy link
Copy Markdown
Contributor Author

tomaka commented Jul 11, 2018

Note that this is not necessarily the right solution. Maybe dirs should be fixed, depending on @niklasad1's opinion.

@ordian
Copy link
Copy Markdown
Contributor

ordian commented Jul 11, 2018

There is also directories crate, which has the same fallback for android as rust.

EDIT: actually it doesn't, ignore my comment.

Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert so we have time to come up with a solution when this gets deprecated!

Copy link
Copy Markdown
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dvdplm dvdplm merged commit 5f05acd into paritytech:master Jul 12, 2018
@tomaka tomaka deleted the revert-9077 branch July 12, 2018 06:53
sorpaas pushed a commit that referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants