Skip to content

Added event MessagesReceived for better visibility on receiving side#1655

Merged
bkontur merged 3 commits into
masterfrom
bko-stackexchange-fix
Nov 21, 2022
Merged

Added event MessagesReceived for better visibility on receiving side#1655
bkontur merged 3 commits into
masterfrom
bko-stackexchange-fix

Conversation

@bkontur
Copy link
Copy Markdown
Collaborator

@bkontur bkontur commented Nov 21, 2022 •
edited
Loading

We generate (messages) events only on source chain, so this adds event on target chain, it could help better understand and see and anaylze what is going on, better visibility, e.g. at least, we could see easily in polkadot.js in what block messages were received.
If this will be too much overhead, later we could remove that or just add there only some counters.

plus trying to fix https://substrate.stackexchange.com/questions/5901/failed-to-run-parity-bridges-common-message-realy-demo/5906?noredirect=1#comment5781_5906

bkontur
bkontur commented Nov 21, 2022
View reviewed changes
Comment thread scripts/send-message-from-millau-rialto.sh
svyatonik
svyatonik approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had dispatch level events before (in bridge dispatch pallet), but now they are gone. So yeah - imo it is a good idea, thank you!

Comment thread primitives/messages/src/lib.rs
Comment thread modules/messages/src/lib.rs Outdated
Comment thread modules/messages/src/lib.rs Outdated
@bkontur bkontur force-pushed the bko-stackexchange-fix branch from 775988a to 464eb29 Compare November 21, 2022 14:35
@bkontur bkontur merged commit 97c68c5 into master Nov 21, 2022
@bkontur bkontur deleted the bko-stackexchange-fix branch November 21, 2022 15:55
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 6, 2023
Companion for paritytech/parity-bridges-common#1655
030a562
boundless-forest pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 12, 2023
Prepare messages-substrate polkadot-v0.9.33 for Darwinia-2.0 (#235)
f98feb6 
* Anchor polkadot-v0.9.32

* fix parity-util-mem conflict

* Anchor polkadot-v0.9.33

* Companion for paritytech/parity-bridges-common#1613

* Companion for paritytech/parity-bridges-common#1616

* Companion for paritytech/parity-bridges-common#1619

* Companion for paritytech/parity-bridges-common#1623

* Companion for paritytech/parity-bridges-common#1622

* Companion for paritytech/parity-bridges-common#1655

* Companion for paritytech/parity-bridges-common#1670

* Companion for paritytech/parity-bridges-common#1690

* Correct cargo

* Revert "Companion for paritytech/parity-bridges-common#1690"

This reverts commit 926b32d.

* Revert "Companion for paritytech/parity-bridges-common#1670"

This reverts commit b96b41c.

* Fix compile

* Revert "Companion for paritytech/parity-bridges-common#1622"

This reverts commit 4c5865d.

* Fix compile

* format

* Fix test

* Fix dispatch test

* Try fix compile with darwinia-2.0

* Revert "Try fix compile with darwinia-2.0"

This reverts commit c9dcd67.

* Update prepare branch

* Format

* Remove unused trait

* Remove unused import
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 17, 2023
Prepare messages-substrate polkadot-v0.9.33 for Darwinia-2.0 (#235)
6951bf8 
* Anchor polkadot-v0.9.32

* fix parity-util-mem conflict

* Anchor polkadot-v0.9.33

* Companion for paritytech/parity-bridges-common#1613

* Companion for paritytech/parity-bridges-common#1616

* Companion for paritytech/parity-bridges-common#1619

* Companion for paritytech/parity-bridges-common#1623

* Companion for paritytech/parity-bridges-common#1622

* Companion for paritytech/parity-bridges-common#1655

* Companion for paritytech/parity-bridges-common#1670

* Companion for paritytech/parity-bridges-common#1690

* Correct cargo

* Revert "Companion for paritytech/parity-bridges-common#1690"

This reverts commit 926b32d.

* Revert "Companion for paritytech/parity-bridges-common#1670"

This reverts commit b96b41c.

* Fix compile

* Revert "Companion for paritytech/parity-bridges-common#1622"

This reverts commit 4c5865d.

* Fix compile

* format

* Fix test

* Fix dispatch test

* Try fix compile with darwinia-2.0

* Revert "Try fix compile with darwinia-2.0"

This reverts commit c9dcd67.

* Update prepare branch

* Format

* Remove unused trait

* Remove unused import
@jiguantong jiguantong mentioned this pull request Jan 17, 2023
Merged
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Jan 17, 2023
Prepare messages-substrate polkadot-v0.9.33 for Darwinia-2.0 (#235) (#…
e5ec426 
…238)

* Anchor polkadot-v0.9.32

* fix parity-util-mem conflict

* Anchor polkadot-v0.9.33

* Companion for paritytech/parity-bridges-common#1613

* Companion for paritytech/parity-bridges-common#1616

* Companion for paritytech/parity-bridges-common#1619

* Companion for paritytech/parity-bridges-common#1623

* Companion for paritytech/parity-bridges-common#1622

* Companion for paritytech/parity-bridges-common#1655

* Companion for paritytech/parity-bridges-common#1670

* Companion for paritytech/parity-bridges-common#1690

* Correct cargo

* Revert "Companion for paritytech/parity-bridges-common#1690"

This reverts commit 926b32d.

* Revert "Companion for paritytech/parity-bridges-common#1670"

This reverts commit b96b41c.

* Fix compile

* Revert "Companion for paritytech/parity-bridges-common#1622"

This reverts commit 4c5865d.

* Fix compile

* format

* Fix test

* Fix dispatch test

* Try fix compile with darwinia-2.0

* Revert "Try fix compile with darwinia-2.0"

This reverts commit c9dcd67.

* Update prepare branch

* Format

* Remove unused trait

* Remove unused import
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
@bkontur
Added event MessagesReceived for better visibility on receiving side (
9476045 
paritytech#1655)

* Added event `MessagesReceived` for better visibility on receiving side

* Fixes/comments from PR

* Final cleanup
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
@bkontur
Added event MessagesReceived for better visibility on receiving side (
97ecb4e 
paritytech#1655)

* Added event `MessagesReceived` for better visibility on receiving side

* Fixes/comments from PR

* Final cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@svyatonik svyatonik svyatonik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkontur @svyatonik