[Deployments] Deduplicate message sending code#1537
Merged
svyatonik merged 2 commits intoparitytech:masterfrom Aug 5, 2022
Merged
[Deployments] Deduplicate message sending code#1537svyatonik merged 2 commits intoparitytech:masterfrom
svyatonik merged 2 commits intoparitytech:masterfrom
Conversation
Signed-off-by: Serban Iorga <serban@parity.io>
svyatonik
approved these changes
Aug 5, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1526
I was playing with the deployments while reviewing #1412 and since I got here I thought it would be an useful exercise for me to also play with some code and address #1526. The approach might not be ideal (it might be nicer to have a script that receives CLI parameters, but it's harder to do from bash). But anyway, it deduplicates some code.