Unprofitable message delivery tx metric#1536
Merged
Merged
Conversation
serban300
reviewed
Aug 15, 2022
Comment on lines
+43
to
+45
| // we don't care about costs and rewards, but we want to report unprofitable transactions | ||
| // => let rational strategy fill required fields | ||
| let _ = RationalStrategy.decide(reference).await; |
Collaborator
There was a problem hiding this comment.
Could we move the entire logic that computes the costs and rewards to a common method (could be defined on the RelayStrategy trait) ? It seems strange to use RationalStrategy.decide() inside AltruisticStrategy.
Contributor
Author
There was a problem hiding this comment.
I'd leave it outside trait, but feel free to implement what you think is better
| true | ||
| } | ||
|
|
||
| async fn final_decision< |
Collaborator
There was a problem hiding this comment.
2 questions:
- Do we need this method to be
async? - This method doesn't seem to be used for taking a decision. Could we rename it to something like
update_metrics?
Contributor
Author
There was a problem hiding this comment.
- If it works without async, let's remove it - it has probably leftover of some early experiments
- I mean something like "notify strategy about final decision", but feel free to rename
Merged
serban300
added a commit
that referenced
this pull request
Aug 18, 2022
* Make RelayStrategy::final_decision() sync Signed-off-by: Serban Iorga <serban@parity.io> * Move logic from RelayStrategy to RelayReference Signed-off-by: Serban Iorga <serban@parity.io> * Rename RelayStrategy::final_decision() Signed-off-by: Serban Iorga <serban@parity.io>
Collaborator
|
The comments were addressed in #1549 . Marking this PR as reviewed. |
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* unprofitable message delivery tx metric * proper impl * send Rialto -> Millau messages using XCM pallet * use altruistic relays in Rialto <> Millau bridge * add unprofitable transactions dashboard * fix + logging * fix test
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Make RelayStrategy::final_decision() sync Signed-off-by: Serban Iorga <serban@parity.io> * Move logic from RelayStrategy to RelayReference Signed-off-by: Serban Iorga <serban@parity.io> * Rename RelayStrategy::final_decision() Signed-off-by: Serban Iorga <serban@parity.io>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* unprofitable message delivery tx metric * proper impl * send Rialto -> Millau messages using XCM pallet * use altruistic relays in Rialto <> Millau bridge * add unprofitable transactions dashboard * fix + logging * fix test
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Make RelayStrategy::final_decision() sync Signed-off-by: Serban Iorga <serban@parity.io> * Move logic from RelayStrategy to RelayReference Signed-off-by: Serban Iorga <serban@parity.io> * Rename RelayStrategy::final_decision() Signed-off-by: Serban Iorga <serban@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1522
WIP