Skip to content

[Complex Relayers] Deduplicate l2r and r2l logic#1535

Merged
svyatonik merged 2 commits into
paritytech:masterfrom
serban300:refactoring_3
Aug 3, 2022
Merged

[Complex Relayers] Deduplicate l2r and r2l logic#1535
svyatonik merged 2 commits into
paritytech:masterfrom
serban300:refactoring_3

Conversation

@serban300
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Serban Iorga <serban@parity.io>
@serban300 serban300 requested a review from svyatonik August 3, 2022 08:00
@serban300 serban300 self-assigned this Aug 3, 2022
Copy link
Copy Markdown
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! One thing that is confusing me is l2r and r2l :) When I've got PR notification I didn't even understand what this PR is about (relayer-to-?). IMO left_to_right and right_to_left gives more context when you look at the code, even though it is longer. But again - it may be my personal preference, so don't consider it as a requirement

@serban300
Copy link
Copy Markdown
Collaborator Author

Looks great, thank you! One thing that is confusing me is l2r and r2l :) When I've got PR notification I didn't even understand what this PR is about (relayer-to-?). IMO left_to_right and right_to_left gives more context when you look at the code, even though it is longer. But again - it may be my personal preference, so don't consider it as a requirement

Makes sense. I wanted to shorten the names a bit, but readability is more important. Done.

@svyatonik svyatonik enabled auto-merge (squash) August 3, 2022 11:04
@svyatonik svyatonik merged commit 24e5a37 into paritytech:master Aug 3, 2022
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
)

Co-authored-by: Alexander Theißen <alex.theissen@me.com>
serban300 added a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
* [Complex Relayers] Deduplicate l2r and r2l logic

Signed-off-by: Serban Iorga <serban@parity.io>

* Renamings
serban300 added a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
* [Complex Relayers] Deduplicate l2r and r2l logic

Signed-off-by: Serban Iorga <serban@parity.io>

* Renamings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants