Refund relayer if parachain head has not been updated#1528
Merged
Conversation
svyatonik
added
P-Runtime
PR-audit-needed
30 tasks
serban300
reviewed
Aug 15, 2022
Collaborator
serban300
left a comment
serban300
left a comment
There was a problem hiding this comment.
Looks good ! Marking the PR as reviewed.
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1440
I was going to use different approach for that initially, but the logic either becomes too complex (parachain head may be rejected at a different levels) or it is almost impossible to do that (e.g. when we have failed to read parachain head from the proof - shall we even try to refund?). So refunding is done similarly to pruning here - we're only refunding if proof is correct, but someone else has already provided better head.