Followu-up un #1468#1525
Merged
Merged
Conversation
Signed-off-by: Serban Iorga <serban@parity.io>
Change Runtime APIs best_finalized() signature to return Option<HeaderId> Signed-off-by: Serban Iorga <serban@parity.io>
serban300
added
the
PR-breaksrelay
svyatonik
approved these changes
Jul 28, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Looks great, thank you!
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* add tag creation for the runtimes release branch * change githab actions versions to hashes Co-authored-by: parity-processbot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the comments in #1468
This PR breaks existing runtime APIs -
best_finalized()now returnsOption<HeaderId<BlockHash, BlockNumber>instead ofOption<(BlockNumber, BlockHash)>.Maybe we should also change the signature of
HeaderIdin the future fromHeaderId<BlockHash, BlockNumber>toHeaderId<BlockNumber, BlockHash>. I find it strange to havepub struct HeaderId<Hash, Number>(pub Number, pub Hash);. But for the moment I used it as it is.