Unify the operating mode for bridge pallets#1483
Merged
serban300 merged 2 commits intoJun 28, 2022
Merged
Conversation
serban300
added
PR-breaksrelay
serban300
force-pushed
the
parachains_operating_mode_and_owner
branch
from
d3cc258 to
0d18874
Compare
svyatonik
approved these changes
Jun 28, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Looks great, thank you! Yep - it breaks both relay and existing runtimes, thanks for proper labeling! Fortunately, apart from Rialto/Millau, we only have those pallets deployed at Rococo/Wococo and we're not going to make any upgrades there - instead this deployment will be deprecated soon.
|
|
||
| /// Operating mode for a bridge module. | ||
| pub trait OperatingMode: Send + Copy + Debug + FullCodec { | ||
| fn is_halted(&self) -> bool; |
Contributor
There was a problem hiding this comment.
Please some docs for this public method
Collaborator
Author
There was a problem hiding this comment.
Sorry, I missed it. Done.
Contributor
There was a problem hiding this comment.
(btw - I still do not see any docs :) )
Collaborator
Author
There was a problem hiding this comment.
Yes, I placed it in the implementation by mistake. Fixed.
serban300
force-pushed
the
parachains_operating_mode_and_owner
branch
from
0d18874 to
b0a40d7
Compare
- define the OperationMode trait and BasicOperatingMode enum - use the OperationMode trait in all the bridge pallets - use BasicOperatingMode instead of IsHalted for the Grandpa pallet - use BasicOperatingMode as part of MessagesOperatingMode Signed-off-by: Serban Iorga <serban@parity.io>
serban300
force-pushed
the
parachains_operating_mode_and_owner
branch
from
b0a40d7 to
0302a4e
Compare
Signed-off-by: Serban Iorga <serban@parity.io>
30 tasks
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
Unify the operating mode for bridge pallets - define the OperationMode trait and BasicOperatingMode enum - use the OperationMode trait in all the bridge pallets - use BasicOperatingMode instead of IsHalted for the Grandpa pallet - use BasicOperatingMode as part of MessagesOperatingMode Signed-off-by: Serban Iorga <serban@parity.io>
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
Unify the operating mode for bridge pallets - define the OperationMode trait and BasicOperatingMode enum - use the OperationMode trait in all the bridge pallets - use BasicOperatingMode instead of IsHalted for the Grandpa pallet - use BasicOperatingMode as part of MessagesOperatingMode Signed-off-by: Serban Iorga <serban@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1479
It breaks runtime compatibility. I think it's also going to break relayers.