Deduplicate owner calls for some pallets#1477
Merged
serban300 merged 1 commit intoJun 27, 2022
Merged
Conversation
serban300
force-pushed
the
parachains_operating_mode_and_owner
branch
from
1ec48e4 to
034e100
Compare
svyatonik
approved these changes
Jun 27, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Seems super-cool, thank you! I've left some comments - feel free to merge whenever you consider PR ready
Avoid duplicate function definitions for: - ensure_owner_or_root() - ensure_not_halted() - set_owner() - set_operating_mode() / set_operational() Signed-off-by: Serban Iorga <serban@parity.io>
serban300
force-pushed
the
parachains_operating_mode_and_owner
branch
from
034e100 to
8473328
Compare
svyatonik
approved these changes
Jun 27, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Perfect, thank you! Hit merge once it is green ;)
Collaborator
Author
@svyatonik Thank you for the review ! I addressed the comments and opened a new issue for changing |
Collaborator
Author
Ah awesome. Thanks ! |
30 tasks
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* [do not merge] ci: try nextest * uncomment jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some simplifications that should make it easier to implement #1434
Avoid duplicate function definitions for: