Store both block number and hash in best finalized storage value#1475
Merged
Conversation
serban300
reviewed
Jul 27, 2022
Collaborator
serban300
left a comment
There was a problem hiding this comment.
Looks good. Marking it as reviewed.
wuminzhe
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Aug 8, 2022
30 tasks
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…itytech#1475) * store both block number and hash in BestFinalized * also fix relay code * spelling
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…itytech#1475) * store both block number and hash in BestFinalized * also fix relay code * spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1368
needs some testing => draft
This breaks existing already deployed pallets.