Skip to content

Store both block number and hash in best finalized storage value#1475

Merged
svyatonik merged 4 commits into
masterfrom
store-block-number-and-hash-in-best-finalized
Jun 24, 2022
Merged

Store both block number and hash in best finalized storage value#1475
svyatonik merged 4 commits into
masterfrom
store-block-number-and-hash-in-best-finalized

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

closes #1368
needs some testing => draft

This breaks existing already deployed pallets.

@svyatonik svyatonik added P-Runtime PR-breaksruntime A PR that is going to break runtime bridge compatibility. We need to be careful with upgrade. labels Jun 24, 2022
@svyatonik svyatonik marked this pull request as ready for review June 24, 2022 12:04
@svyatonik svyatonik enabled auto-merge (squash) June 24, 2022 12:04
@svyatonik svyatonik merged commit 5781c32 into master Jun 24, 2022
@svyatonik svyatonik deleted the store-block-number-and-hash-in-best-finalized branch June 24, 2022 12:37
Copy link
Copy Markdown
Collaborator

@serban300 serban300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Marking it as reviewed.

wuminzhe pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Aug 8, 2022
svyatonik pushed a commit that referenced this pull request Jul 17, 2023
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
…itytech#1475)

* store both block number and hash in BestFinalized

* also fix relay code

* spelling
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
…itytech#1475)

* store both block number and hash in BestFinalized

* also fix relay code

* spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-Runtime PR-breaksruntime A PR that is going to break runtime bridge compatibility. We need to be careful with upgrade.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store best finalized header id (hash + number) instead of just hash in bridge-grandpa pallet

2 participants