Signed extension for rejecting obsolete messages pallet transactions#1446
Merged
Conversation
svyatonik
added
P-Runtime
P-Message Delivery
PR-audit-needed
This was referenced Jun 9, 2022
serban300
reviewed
Jul 27, 2022
Collaborator
serban300
left a comment
serban300
left a comment
There was a problem hiding this comment.
Looks good ! Marking the PR as reviewed.
30 tasks
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…aritytech#1446) * BridgeRejectObsoleteMessages * add obsolete confirmations verification to the BridgeRejectObsoleteMessages * move tests where they belong
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…aritytech#1446) * BridgeRejectObsoleteMessages * add obsolete confirmations verification to the BridgeRejectObsoleteMessages * move tests where they belong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs:
bridges-runtime-common?This extension depends on types from the
bridges-runtime-commoncrate, so it is also sitting there (unlike other extensions, which reside in the pallets code).This PR breaks several runtime APIs (not storage). So it'll made existing relays incompatible with updated pallets and existing pallets incompatible with updated relays.