Rename CheckBridgedBlockNumber to BridgeRejectObsoleteGrandpaHeader#1442
Merged
Conversation
svyatonik
added
the
A-chores
30 tasks
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* companion for paritytech/polkadot#5770 * update lockfile for {"polkadot", "substrate"} Co-authored-by: parity-processbot <>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: I'm working on similar extension for parachains pallet. And the same name (
CheckBridgedBlockNumber) may be used to identify that new extension as well. So I've changed name to be more specific (mention pallet name) and actually report what it does (so "reject obsolete header" instead of unclear "check block number").