Skip to content

Small opt when prune messages #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svyatonik merged 2 commits into from
May 6, 2022
Merged

Small opt when prune messages #1389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fb1f68
Small opt when prune messages
hujw77 May 5, 2022
630c036
Fix typing error
hujw77 May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions modules/messages/src/outbound_lane.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,19 +148,17 @@ impl<S: OutboundLaneStorage> OutboundLane<S> {
/// Returns number of pruned messages.
pub fn prune_messages(&mut self, max_messages_to_prune: MessageNonce) -> MessageNonce {
let mut pruned_messages = 0;
let mut anything_changed = false;
let mut data = self.storage.data();
while pruned_messages < max_messages_to_prune &&
data.oldest_unpruned_nonce <= data.latest_received_nonce
{
self.storage.remove_message(&data.oldest_unpruned_nonce);

anything_changed = true;
pruned_messages += 1;
data.oldest_unpruned_nonce += 1;
}

if anything_changed {
if pruned_messages > 0 {
self.storage.set_data(data);
}

Expand Down