Conversation
Right now, each time there is an error while executing `substrate-relay`
it will be reported as:
ERROR bridge Failed to start relay: <Actual cause of error>
This is the case even if the invoked command did not have anything to do
with starting a relayer. Thus this removes this text. Now something like
this would be written:
ERROR bridge <Actual cause of error>
pepyakin
added
the
A-chores
svyatonik
approved these changes
May 5, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Imo it's more about binary (which is called substrate-relay), not the subcommand that actually perform relay-related tasks. I'll approve - feel free to merge if you think it's better than what we have now
Contributor
Author
|
ah, it's the same as in well, that was not obvious. Also, I think it still does not have anything to do with "starting". |
Contributor
Author
|
Perhaps, 1260f5d makes more sense? |
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Companion: Bump syn * Update Substrate & Polkadot
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Generalize error text
Right now, each time there is an error while executing `substrate-relay`
it will be reported as:
ERROR bridge Failed to start relay: <Actual cause of error>
This is the case even if the invoked command did not have anything to do
with starting a relayer. Thus this removes this text. Now something like
this would be written:
ERROR bridge <Actual cause of error>
* Use substrate-relay prefix
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Generalize error text
Right now, each time there is an error while executing `substrate-relay`
it will be reported as:
ERROR bridge Failed to start relay: <Actual cause of error>
This is the case even if the invoked command did not have anything to do
with starting a relayer. Thus this removes this text. Now something like
this would be written:
ERROR bridge <Actual cause of error>
* Use substrate-relay prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, each time there is an error while executing
substrate-relayit will be reported as:
This is the case even if the invoked command did not have anything to do
with starting a relayer. Thus this removes this text. Now something like
this would be written: