Remove support for encoded-call messaging from relay and runtime integration code#1376
Merged
Conversation
|
@svyatonik We are replacing the offchain relay part using subquery indexing, including optimization for mandatory blocks and Justification. It will be a fork/different implementation, so I think relayer client part will be OK for us. For on-chain part, as I understand, the changes will be related to the format of the bridge message, from dispatch call to unified XCM. We'll keep an eye on this, especially Currently using production bridges, Darwinia <> Crab, and Crab <> Crab Parachain is on the way. |
Contributor
Author
|
@acatangiu It should be ready for review. The result of this PR:
|
acatangiu
approved these changes
May 4, 2022
This was referenced May 12, 2022
Closed
This was referenced May 12, 2022
Closed
jiguantong
added a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Oct 26, 2022
10 tasks
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Oct 31, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Oct 31, 2022
jiguantong
added a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Nov 3, 2022
jiguantong
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Apr 11, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…gration code (paritytech#1376) * remove support for encoded-call messaging * continue cleanup * continue cleanup * continue cleanup * more cleanpup * more cleanup * fmt * continue cleanup * spellcheck * rename * fix benchmarks * mention encoded-calls-messaging tag * fixing deployments * fix messages generation * fmt
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…gration code (paritytech#1376) * remove support for encoded-call messaging * continue cleanup * continue cleanup * continue cleanup * more cleanpup * more cleanup * fmt * continue cleanup * spellcheck * rename * fix benchmarks * mention encoded-calls-messaging tag * fixing deployments * fix messages generation * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this PR early (it'll be merged not earlier than on monday evening) to give those who are building using our codebase a chance to prepare. So we'll concentrate on supporting XCM dispatch in our bridge in next month(s). What it means:
pallet-bridge-dispatchandpallet-token-swap(which depends on the former pallet) from our codebase;pallet-bridge-grandpaandpallet-bridge-messages) are staying and will likely keep the same API (this may be changed in next XCM-related milestones though). It means that if you're using encoded-calls messaging, nothing changes for your runtime, except that you won't be able to use following runtime-related crates from our repo:bp-message-dispatch,pallet-bridge-dispatchandbridge-runtime-commonwhich will be changed to support XCM delivery. We'll make a tag before merging this PR and a comment in top-level readme, referencing this tag;send-message,encode-message,estimate-fee) will be changed to support XCM messaging.Pinging guys from Darwinia, as I know you're using some of our crates: @AurevoirXavier @fewensa @hackfisher