Skip to content

Remove support for encoded-call messaging from relay and runtime integration code#1376

Merged
svyatonik merged 16 commits into
masterfrom
remove-encoded-call-messaging
May 4, 2022
Merged

Remove support for encoded-call messaging from relay and runtime integration code#1376
svyatonik merged 16 commits into
masterfrom
remove-encoded-call-messaging

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

I'm opening this PR early (it'll be merged not earlier than on monday evening) to give those who are building using our codebase a chance to prepare. So we'll concentrate on supporting XCM dispatch in our bridge in next month(s). What it means:

  • we've decided to drop support for encoded-call messaging from relay and runtime integration code, because it'll be too hard now to support the stuff that we're not going to use in the near future;
  • we'll remove pallet-bridge-dispatch and pallet-token-swap (which depends on the former pallet) from our codebase;
  • core pallets of our bridge (pallet-bridge-grandpa and pallet-bridge-messages) are staying and will likely keep the same API (this may be changed in next XCM-related milestones though). It means that if you're using encoded-calls messaging, nothing changes for your runtime, except that you won't be able to use following runtime-related crates from our repo: bp-message-dispatch, pallet-bridge-dispatch and bridge-runtime-common which will be changed to support XCM delivery. We'll make a tag before merging this PR and a comment in top-level readme, referencing this tag;
  • headers/messages/headers+messages relay will likely keep supporting both options - XCM messaging and encoded-call messaging. However all subcommands that we were using for tests (send-message, encode-message, estimate-fee) will be changed to support XCM messaging.

Pinging guys from Darwinia, as I know you're using some of our crates: @AurevoirXavier @fewensa @hackfisher

@svyatonik svyatonik added A-chores Something that has to be done, as part of regular maintenance PR-breaksrelay A PR that is going to break existing relayers. I.e. some Runtime changes render old relayers unusabl PR-breaksruntime A PR that is going to break runtime bridge compatibility. We need to be careful with upgrade. labels Apr 22, 2022
@hackfisher
Copy link
Copy Markdown

hackfisher commented Apr 24, 2022

@svyatonik We are replacing the offchain relay part using subquery indexing, including optimization for mandatory blocks and Justification. It will be a fork/different implementation, so I think relayer client part will be OK for us.

For on-chain part, as I understand, the changes will be related to the format of the bridge message, from dispatch call to unified XCM. We'll keep an eye on this, especially bridge-dispatch and see how to upgrade the protocols.

Currently using production bridges, Darwinia <> Crab, and Crab <> Crab Parachain is on the way.

@svyatonik svyatonik requested a review from acatangiu April 25, 2022 14:58
@svyatonik svyatonik marked this pull request as ready for review April 25, 2022 14:59
@svyatonik
Copy link
Copy Markdown
Contributor Author

@acatangiu It should be ready for review. The result of this PR:

  • we have dropped encoded-call messaging. There may be some leftovers though, but in general there's no "official" runtime+relay support for that from now on;
  • on our test deployments we are now generating + delivering simple blobs;
  • dispatch of blob = simple logging for now. Later on, when we'll plugin XCM, we'll be using XCM dispatcher instead

@svyatonik svyatonik merged commit b3d7011 into master May 4, 2022
@svyatonik svyatonik deleted the remove-encoded-call-messaging branch May 4, 2022 12:05
jiguantong added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Oct 26, 2022
jiguantong added a commit to darwinia-network/darwinia-parachain that referenced this pull request Oct 31, 2022
jiguantong added a commit to darwinia-network/darwinia-parachain that referenced this pull request Oct 31, 2022
jiguantong added a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Nov 3, 2022
jiguantong pushed a commit to darwinia-network/darwinia-messages-substrate that referenced this pull request Apr 11, 2023
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
…gration code (paritytech#1376)

* remove support for encoded-call messaging

* continue cleanup

* continue cleanup

* continue cleanup

* more cleanpup

* more cleanup

* fmt

* continue cleanup

* spellcheck

* rename

* fix benchmarks

* mention encoded-calls-messaging tag

* fixing deployments

* fix messages generation

* fmt
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
…gration code (paritytech#1376)

* remove support for encoded-call messaging

* continue cleanup

* continue cleanup

* continue cleanup

* more cleanpup

* more cleanup

* fmt

* continue cleanup

* spellcheck

* rename

* fix benchmarks

* mention encoded-calls-messaging tag

* fixing deployments

* fix messages generation

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-chores Something that has to be done, as part of regular maintenance PR-breaksrelay A PR that is going to break existing relayers. I.e. some Runtime changes render old relayers unusabl PR-breaksruntime A PR that is going to break runtime bridge compatibility. We need to be careful with upgrade.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants