Skip to content

add api data() for inbound_lane#1373

Merged
svyatonik merged 1 commit into
paritytech:masterfrom
xiaoch05:master
Apr 14, 2022
Merged

add api data() for inbound_lane#1373
svyatonik merged 1 commit into
paritytech:masterfrom
xiaoch05:master

Conversation

@xiaoch05
Copy link
Copy Markdown
Contributor

in outbound lane we have opened the data() api
but in the inbound lane this api is not opened, it's very useful for application using the bridge.

@cla-bot-2021
Copy link
Copy Markdown

cla-bot-2021 Bot commented Apr 13, 2022

User @xiaoch05, please sign the CLA here.

@svyatonik svyatonik merged commit 82698e3 into paritytech:master Apr 14, 2022
@svyatonik
Copy link
Copy Markdown
Contributor

it's very useful for application using the bridge.

@xiaoch05 Is there an example of such application? InboundLane is a private struct, so you application must be somewhere in the pallet code, right? Can you provide us with details of you app and how it uses the InboundLane? The fact is that this commit generates annoying compilation warning and unless we'll have a strong evidence of how/why it is used, I'd like this commit to be reverted.

Thank you!

@xiaoch05
Copy link
Copy Markdown
Contributor Author

xiaoch05 commented Apr 22, 2022

it's very useful for application using the bridge.

@xiaoch05 Is there an example of such application? InboundLane is a private struct, so you application must be somewhere in the pallet code, right? Can you provide us with details of you app and how it uses the InboundLane? The fact is that this commit generates annoying compilation warning and unless we'll have a strong evidence of how/why it is used, I'd like this commit to be reverted.

Thank you!

Hi @svyatonik , the previous version supported getting this interface for InboundLane, and we were using it here, emitting an event to correspond with the message in the source chain. But I find that we are able to get all the information we need from these events https://github.com/paritytech/parity-bridges-common/blob/master/modules/dispatch/src/lib.rs#L114-L135, so I changed my previous thought that this interface is not that important for the application. If there is a compilation warning, I think it would be better to revert this modification too.

@svyatonik
Copy link
Copy Markdown
Contributor

Thank you. Yep, I'll revert it then to avoid unnecessary warnings :)

svyatonik added a commit that referenced this pull request Apr 22, 2022
svyatonik added a commit that referenced this pull request Apr 22, 2022
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants