Add rialto-parachain runtime and node#1142
Merged
Merged
Conversation
Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442 Cumulus: d5284b0
Substrate: 630422d6108cbaaca893ab213dde69f3bdaa1f6b Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442 Cumulus: 5af2990 GrandpaBridgeGadget: c152c45ac331eb8ab40d956ab1d008d181810ef4
Contributor
Author
|
// The problem with this PR is that it does two simultaneous things: (1) updates S+P+C references and (2) introduces rialto-parachain. Now we have https://github.com/paritytech/parity-bridges-common/tree/rialto-as-relay-chain that works, but I can't reference the same S+P+C commits, because cargo goes mad. And now, after updating to somewhat-latest commits, I have parachain that isn't producing blocks. So it'll take another significant amount of time to take the same path as 2 months ago to make it work || I'll be able to beat cargo here. |
tomusdrw
approved these changes
Sep 20, 2021
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
So it'll take another significant amount of time to take the same path as 2 months ago to make it work || I'll be able to beat cargo here.
Can we merge as-is and fix the parachain in a follow up PR?
This is mostly parachain-bootstrapping boileplate code afaict, so I don't think it's worth to give it weeks-long review, hence I'm blanket approving and feel free to merge as soon as you are comfortable and work on fixes later.
Contributor
Author
|
For the record:
|
Contributor
Author
|
// IGNORE ME |
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax rules in accordance to https://github.com/paritytech/pr-custom-review/blob/da1d81b9fd39705cc8b37f59235283801c818708/rules.md
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Substrate: 63b32fbaa2764c0a8ee76b70cdfa0fcb59b7181f Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442 Cumulus: d5284b0 * rialto parachain runtime * fixed tests * add node + bump refs (not compiling yet): Substrate: 630422d6108cbaaca893ab213dde69f3bdaa1f6b Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442 Cumulus: 5af2990 GrandpaBridgeGadget: c152c45ac331eb8ab40d956ab1d008d181810ef4 * fix compilation (collator is not working) * more fixes * fmt * spellcheck * fix warnings * fix compilation * fmt * trigger CI * trigger CI * Revert "trigger CI" This reverts commit a31f53c. * benchmarks * fix benchmarks * fix again * Revert "Revert "trigger CI"" This reverts commit 1dea8b4. * Revert "Revert "Revert "trigger CI""" This reverts commit 8fb74fa. * try fix * lost lock file * spellcheck * try to disable sccache for cargo check * Revert "Revert "Revert "Revert "trigger CI"""" This reverts commit f157461. * try to disable again * disable sccache for test
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Substrate: 63b32fbaa2764c0a8ee76b70cdfa0fcb59b7181f Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442 Cumulus: d5284b0 * rialto parachain runtime * fixed tests * add node + bump refs (not compiling yet): Substrate: 630422d6108cbaaca893ab213dde69f3bdaa1f6b Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442 Cumulus: 5af2990 GrandpaBridgeGadget: c152c45ac331eb8ab40d956ab1d008d181810ef4 * fix compilation (collator is not working) * more fixes * fmt * spellcheck * fix warnings * fix compilation * fmt * trigger CI * trigger CI * Revert "trigger CI" This reverts commit a31f53c. * benchmarks * fix benchmarks * fix again * Revert "Revert "trigger CI"" This reverts commit 1dea8b4. * Revert "Revert "Revert "trigger CI""" This reverts commit 8fb74fa. * try fix * lost lock file * spellcheck * try to disable sccache for cargo check * Revert "Revert "Revert "Revert "trigger CI"""" This reverts commit f157461. * try to disable again * disable sccache for test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Substrate: 63b32fbaa2764c0a8ee76b70cdfa0fcb59b7181f
Polkadot: 7229ab87acf5bc5d4d10655ad1a9819a1e317442
Cumulus: d5284b0
When this PR will be finished, we'll have parachain (node + runtime) that may be manually registered + started.
Tasks for next PRs (to give a brief overview of what we have now and what we should have ideally):
Once this is done, we'll have Millau <> RialtoParachain bridge + optionally Millau <> Rialto bridge. If we want to build MillauParachain <> RialtoParachain bridge, it may done after all this ^^^.