-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check lane id of incoming messages #2452
Comments
@svyatonik and next week on CGP retreat, I would like to disccuss this and other stuff with Joe, so after that, I would be able to align all similar configurations and do it in one way |
@bkontur to recheck it |
* Add try-runtime feature Signed-off-by: Oliver Tale-Yazdi <[email protected]> * More feature gates Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add dummy command Signed-off-by: Oliver Tale-Yazdi <[email protected]> * update lockfile for {"polkadot", "substrate"} * Fix code * Remove unused import Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Imports... Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fmt Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fmt Signed-off-by: Oliver Tale-Yazdi <[email protected]> Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <>
@bkontur to recheck it |
@svyatonik
the only usage of |
## Summary This PR aligns Rococo/Westend bridge with latest Bridges repo development: - paritytech/parity-bridges-common#2727 - paritytech/parity-bridges-common#2728 - paritytech/parity-bridges-common#2729 Part of: paritytech/parity-bridges-common#2452
slightly related to https://github.com/paritytech/srlabs_findings/issues/142
We shall verify lane of incoming messages - something that we already had before, but lost now. With XCM bridge it means:
[0, 0, 0, 1]
for messages between *mint/*mine chains) - we shall return error fromverify_messages_proof
if proof contains messages from some other lane. Now this is some static check, but later we'll probably need to maintain map ofLaneId => (XcmSource, XcmDestination)
;[0, 0, 0, 1]
to WBH, we want to ensure that it has been actually sent by Rockime2 and is going to Wockmint. Can we do that, or is it handled somewhere already? WDYT about that?@bkontur @serban300 Can you, guys, please, tackle this?
The text was updated successfully, but these errors were encountered: