Use crates from RustCrypto organization and remove rust-crypto crate.#517
Closed
jeandudey wants to merge 1 commit into
Closed
Use crates from RustCrypto organization and remove rust-crypto crate.#517jeandudey wants to merge 1 commit into
rust-crypto crate.#517jeandudey wants to merge 1 commit into
Conversation
|
It looks like @jeandudey signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
svyatonik
reviewed
Aug 8, 2018
| use siphasher::sip::SipHasher24; | ||
| use primitives::hash::{H32, H160, H256}; | ||
|
|
||
| pub use digest::Digest; |
Contributor
There was a problem hiding this comment.
Seems like pub use is not really required here.
Contributor
Author
There was a problem hiding this comment.
@svyatonik chain depends on Digest being re-exported by bitcrypto, also it's a common pattern in RustCrypto crates to re-export the Digest trait.
svyatonik
added
the
A5-grumble
Contributor
|
I have pretty much the same concerns as here: paritytech/parity-common#14 (review) I think we should all talk internally whether we want to commit to RustCrypto, before accepting these prs :) |
svyatonik
added
the
A1-onice
jeandudey
force-pushed
the
2018-08-07-rust-crypto
branch
from
b5b07c4 to
ab86346
Compare
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
jeandudey
force-pushed
the
2018-08-07-rust-crypto
branch
from
ab86346 to
d9adc0b
Compare
svyatonik
removed
the
A5-grumble
Contributor
Author
|
@mkjekk I'm sorry, what's that? |
ngoctrantl
approved these changes
Jun 27, 2019
Contributor
Author
|
Closing due to lost of interest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.