Reclaim request id for unsubscribe requests #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ech/jsonrpsee into return-request-id-on-unsubscribe
Contributor
Hmm, really? Please open issue |
Contributor
Author
|
Yeah - I'm getting this when trying to run UPD: actually removing |
dvdplm
reviewed
Apr 19, 2021
| } | ||
|
|
||
| #[tokio::test] | ||
| #[ignore] |
Contributor
There was a problem hiding this comment.
What is this about, are these tests failing even with this fix?
Contributor
There was a problem hiding this comment.
the nodes have been down so ignored those for now ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsubscribe request is sent, the
send_backisNone(see here). When response to this request is received, the request id is not reclaimed by the request manager (see this and this) => if app starts and drops subscriptions, it'll end up with MaxSlotsExceeded error. Like it already happened in paritytech/parity-bridges-common#909 .Unfortunately, I'm unable to compile master branch of
jsonrpseewith latest stable rust => can't run tests and see if this patch breaks something. But at least applying this patch to the alpha.4 solves our issue.