This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Derive scale_info::TypeInfo for types used in polkadot#218
Merged
Conversation
scale-info::TypeInfo for types used in polkadotscale_info::TypeInfo for types used in polkadot
2 tasks
Contributor
Author
|
Hey @tomusdrw what's the process for merging "companion" PRs here, which depend on a substrate PR? Specifically paritytech/substrate#8615. That PRs companion polkadot PR depends on this, which in turn depends on the substrate PR ( |
Contributor
|
There is no clear process yet, until the companion system is expanded to this repo. I see couple options though:
TBH I'm most in favour of option (4), but it requires a bit more work on your side. However I'm going to be happy with any of these - excited to see this stuff in. |
tomusdrw
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/polkadot#3336.