Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Derive scale_info::TypeInfo for types used in polkadot#218

Merged
tomusdrw merged 18 commits into
masterfrom
aj-metadata-vnext
Jul 30, 2021
Merged

Derive scale_info::TypeInfo for types used in polkadot#218
tomusdrw merged 18 commits into
masterfrom
aj-metadata-vnext

Conversation

@ascjones
Copy link
Copy Markdown
Contributor

@ascjones ascjones commented Jun 22, 2021

Companion for paritytech/polkadot#3336.

@ascjones ascjones changed the title Derive scale-info::TypeInfo for types used in polkadot Derive scale_info::TypeInfo for types used in polkadot Jul 5, 2021
@ascjones ascjones marked this pull request as ready for review July 5, 2021 15:31
@ascjones
Copy link
Copy Markdown
Contributor Author

ascjones commented Jul 30, 2021

Hey @tomusdrw what's the process for merging "companion" PRs here, which depend on a substrate PR? Specifically paritytech/substrate#8615.

That PRs companion polkadot PR depends on this, which in turn depends on the substrate PR (sp-core).

@tomusdrw
Copy link
Copy Markdown
Contributor

There is no clear process yet, until the companion system is expanded to this repo. I see couple options though:

  1. Split sp-core changes into a separate substrate PR, so that we can merge this one easily.
  2. Merge this PR anticipating quick merge of both Substrate & Polkadot companions (this would render our repo's CI broken for a brief period)
  3. Merge Substrate PR with companion failing and then merge this PR.
  4. Add temporary patch to polkadot companion to use aj-metadata-vnext branch for BEEFY components to make the CI green. Then either merge this and revert or merge polkadot and merge this & revert polkadot patch later.

TBH I'm most in favour of option (4), but it requires a bit more work on your side. However I'm going to be happy with any of these - excited to see this stuff in.

@tomusdrw tomusdrw enabled auto-merge (squash) July 30, 2021 09:47
@tomusdrw tomusdrw merged commit f5c77a3 into master Jul 30, 2021
@tomusdrw tomusdrw deleted the aj-metadata-vnext branch July 30, 2021 10:14
@ascjones ascjones mentioned this pull request Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants