Conversation
464b791 to
8091da2
Compare
15837bc to
aaa10f3
Compare
aaa10f3 to
54d85db
Compare
1ec298b to
222eb3e
Compare
stiiifff
reviewed
Aug 14, 2023
cf474a4 to
7d3bcda
Compare
7d3bcda to
6c00e77
Compare
stiiifff
approved these changes
Aug 15, 2023
Contributor
|
Great job @weezy20, LGTM ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes :
pallet-evmhas a new config itemGasLimitPovSizeRatio. The basic function of this item is to give an account of the proof-size based off the gas limit of an EVM transaction. It is the ratio ofBLOCK_GAS_LIMIT : (G)andMAX_POV_SIZE : (P). To understand how a proof size is obtained, we consider a simple relation: whereg= gas limit of the tx andp= the proof size we are trying to estimate :GasLimitPovSizeRatio=G / P == g / p=>p = g / GasLimitPovSizeRatioFor a more elaborate discussion please visit https://forum.polkadot.network/t/frontier-support-for-evm-weight-v2/2470
Introduction of
FeePolynomialinWeightToFeeimplementationChanges to
EthereumRuntimeRPCApicallandcreatemethods to introduce external cost recording in non-transactional calls, More details can be found here : EVM + Weight v2 support polkadot-evm/frontier#1039Runtime changes from Uplift dependencies to polkadot-v0.9.42 extended-parachain-template#27.
Updates to the node to make it all work harmoniously.
Free up space in GH runner and add rust-cache (EPT #36) to make CI pass and avoid the infamous
No space left on deviceAdditional changes : close Add pallet-motion benchmarks #10
Remove frontier offchain DB on PurgeChain #12