Update to latest scale-info & codec, remove string parameterization #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Feb 11, 2021
|
|
||
| impl Encode for DefaultByteGetter { | ||
| fn encode_to<W: Output>(&self, dest: &mut W) { | ||
| fn encode_to<W: Output + ?Sized>(&self, dest: &mut W) { |
Contributor
There was a problem hiding this comment.
Do you know what lies behind the relaxed bounds requirement here, i.e. ?Sized? I know it came with scale 2.0 but I'm hazy on why.
Member
There was a problem hiding this comment.
So that the output can be unsized. So you could for example have some boxed output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to use new
decodefeature inscale-infofor environments where decoding is enabled, which removes the hacky string parameterization. See paritytech/scale-info#59todo