Skip to content

Fix timestamp clamping to prevent overflow when converting to milliseconds #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filip-parity merged 1 commit into from
Feb 2, 2026
+7 −6
Merged

Fix timestamp clamping to prevent overflow when converting to milliseconds #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions crates/revive-strategy/src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,20 +174,21 @@ impl TestEnv {

pub fn set_timestamp(&mut self, new_timestamp: U256) -> U256 {
// Set timestamp in pallet-revive runtime (milliseconds).
// We clamp to u64::MAX / 1000 to prevent overflow when converting to milliseconds.
self.0.lock().unwrap().externalities.execute_with(|| {
let u64_max = U256::from(u64::MAX);
let clamped_timestamp = if new_timestamp > u64_max {
let max_timestamp_seconds = U256::from(u64::MAX / 1000);
let clamped_timestamp = if new_timestamp > max_timestamp_seconds {
tracing::warn!(
timestamp = ?new_timestamp,
max = ?u64_max,
"Timestamp exceeds u64::MAX. Clamping to u64::MAX."
max = ?max_timestamp_seconds,
"Timestamp exceeds maximum. Clamping to u64::MAX / 1000."
);
u64_max
max_timestamp_seconds
} else {
new_timestamp
};

let timestamp_ms = clamped_timestamp.saturating_to::<u64>().saturating_mul(1000);
let timestamp_ms = clamped_timestamp.saturating_to::<u64>() * 1000;
Timestamp::set_timestamp(timestamp_ms);
clamped_timestamp
})
Expand Down
Loading