Fund etched contract for storage deposit#495
Closed
filip-parity wants to merge 1 commit intomasterfrom
Closed
Conversation
pkhry
reviewed
Jan 18, 2026
| contract_info, | ||
| ); | ||
|
|
||
| Pallet::<Runtime>::set_evm_balance(&target_address, u128::MAX.into()) |
|
can you add a repro test case? |
smiasojed
reviewed
Jan 19, 2026
| .load_account(*target) | ||
| .map(|acc| acc.info.balance) | ||
| .unwrap_or_default(); | ||
| // Ensure minimum balance for storage deposits if the account has no balance set. |
Collaborator
There was a problem hiding this comment.
if no balance is set how the caller will paid for call execution? I guess it should fail even in the foundry REVM?
Author
There was a problem hiding this comment.
We're setting balance for the callee to pay storage deposits. It doesn't fail in standard REVM because storage doesn't cost balance there.
smiasojed
reviewed
Jan 19, 2026
filip-parity
force-pushed
the
filip/etched_deposit
branch
from
d533528 to
c81a431
Compare
Author
Added this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fund the etched contract so it can pay for storage deposits in Polkadot's storage deposit model, contracts need balance to store data.