Skip to content

anvil-polkadot: add genesis coinbase support #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 28, 2025
Merged

anvil-polkadot: add genesis coinbase support #355

merged 29 commits into from
Oct 28, 2025

Conversation

@iulianbarbu
Copy link

@iulianbarbu iulianbarbu commented Oct 22, 2025 •
edited by ezusthold-tpm
Loading

Motivation

Implement coinbase setup at genesis or through anvil_setCoinbase and getter through eth_coinbase.

Rely on pallet-aura storage keys, especially Authorities, and implement a manual seal consensus data provider that provides digests referring to slot 0, which should be usable by an assethub fork, when computing the slot for the authority that should be picked with FindAuthor pallet_aura impl.

TODO

  • manual test for anvil_setCoinbase/eth_coinbase via cast.
  • integration tests for RPC & contract call to coinbase
  • unit test for coinbase setup at genesis

@iulianbarbu iulianbarbu self-assigned this Oct 22, 2025
@iulianbarbu iulianbarbu added the enhancement New feature or request label Oct 22, 2025
@iulianbarbu iulianbarbu linked an issue Oct 22, 2025 that may be closed by this pull request
[Anvil] Genesis customisation #241
Closed
@iulianbarbu iulianbarbu marked this pull request as ready for review October 23, 2025 13:43
alindima
alindima reviewed Oct 24, 2025
View reviewed changes
alindima
alindima approved these changes Oct 27, 2025
View reviewed changes
iulianbarbu
iulianbarbu commented Oct 27, 2025
View reviewed changes
re-gius
re-gius approved these changes Oct 27, 2025
View reviewed changes
Copy link

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few nits

@alindima alindima mentioned this pull request Oct 28, 2025
Closed
@iulianbarbu iulianbarbu enabled auto-merge (squash) October 28, 2025 14:51
@iulianbarbu iulianbarbu disabled auto-merge October 28, 2025 14:51
@iulianbarbu iulianbarbu enabled auto-merge (squash) October 28, 2025 14:54
@iulianbarbu iulianbarbu merged commit 5d0dbc9 into master Oct 28, 2025
19 of 30 checks passed
@iulianbarbu iulianbarbu deleted the ib-add-genesis-coinbase-support branch October 28, 2025 16:19
@iulianbarbu
Copy link
Author

iulianbarbu commented Oct 29, 2025

Opened #369 for the technical debt created here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alindima alindima alindima approved these changes

@re-gius re-gius re-gius approved these changes

@AlexandruCihodaru AlexandruCihodaru Awaiting requested review from AlexandruCihodaru

Assignees

@iulianbarbu iulianbarbu

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Anvil] Genesis customisation

5 participants

@iulianbarbu @alindima @re-gius @pkhry