anvil: state injector #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
reviewed
Sep 26, 2025
| call_data: &[u8], | ||
| context: CallContext, | ||
| ) -> sp_blockchain::Result<Vec<u8>> { | ||
| if context == CallContext::Offchain { |
There was a problem hiding this comment.
Hmm why is this? You will need to apply the overlay also in Onchain context such as block building and so on, right?
There was a problem hiding this comment.
On chain, we always use contextual_call (since it needs the in-memory overlay), as far as I've seen. Otherwise I would have hit the infinite recursion I accidentally added here 😅
re-gius
reviewed
Oct 13, 2025
| use substrate_runtime::Balance; | ||
|
|
||
| #[derive(Debug, thiserror::Error)] | ||
| pub enum BackendError { |
There was a problem hiding this comment.
What about a NotFound error with a string/enum saying what's missing (total issuance, chain id, ...) and a DecodingFailed error with a string/enum saying what's failing (total issuance, chain id, ...)
AlexandruCihodaru
approved these changes
Oct 14, 2025
| NonceOverflow, | ||
| #[error(transparent)] | ||
| RuntimeApi(#[from] sp_api::ApiError), | ||
| #[error("Error encountered while creating a BalanceWithDust from a U256 balance")] |
There was a problem hiding this comment.
nit: I would not specify the internal types in the error message.
Comment on lines
+70
to
+76
| assert_matches!( | ||
| node.send_transaction(tx, None).await, | ||
| Err(RpcError {code, message, ..}) => { | ||
| assert_eq!(code, ErrorCode::InternalError); | ||
| message.contains("Invalid Transaction") | ||
| } | ||
| ); |
re-gius
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #240.