Skip to content

Don't use more core modules than Substrate does without "std".#86

Merged
jimpo merged 1 commit intoparitytech:masterfrom
jimpo:de-stdify
Oct 1, 2019
Merged

Don't use more core modules than Substrate does without "std".#86
jimpo merged 1 commit intoparitytech:masterfrom
jimpo:de-stdify

Conversation

@jimpo
Copy link
Contributor

@jimpo jimpo commented Sep 30, 2019

This prepares the crate to be used by a Substrate module without requiring more core crate modules than SRML uses already. The main difficulty is in removing the use of core::fmt.

Fixes #85.

Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits. lgtm otherwise.

@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #86 into master will decrease coverage by 0.56%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   88.19%   87.62%   -0.57%     
==========================================
  Files          10       10              
  Lines        2491     2506      +15     
==========================================
- Hits         2197     2196       -1     
- Misses        294      310      +16
Impacted Files Coverage Δ
src/testing.rs 89.75% <ø> (ø) ⬆️
src/vote_graph.rs 96.95% <100%> (ø) ⬆️
src/bitfield.rs 79.62% <37.5%> (-1.51%) ⬇️
src/round.rs 93.02% <42.85%> (-0.62%) ⬇️
src/lib.rs 80.7% <50%> (-3.45%) ⬇️
src/voter_set.rs 96.66% <50%> (-3.34%) ⬇️
src/voter/mod.rs 82.84% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455cdca...0c173bf. Read the comment docs.

This prepares the crate to be used by a Substrate module without
requiring more core crate modules than SRML uses already. The main
difficulty is in removing the use of core::fmt.
@jimpo jimpo merged commit d4be894 into paritytech:master Oct 1, 2019
@jimpo jimpo deleted the de-stdify branch October 1, 2019 07:39
@andresilva andresilva mentioned this pull request Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove std::fmt dependency without "std" feature

3 participants

Comments