Don't use more core modules than Substrate does without "std".#86
Merged
jimpo merged 1 commit intoparitytech:masterfrom Oct 1, 2019
Merged
Don't use more core modules than Substrate does without "std".#86jimpo merged 1 commit intoparitytech:masterfrom
jimpo merged 1 commit intoparitytech:masterfrom
Conversation
andresilva
approved these changes
Sep 30, 2019
Contributor
andresilva
left a comment
There was a problem hiding this comment.
minor nits. lgtm otherwise.
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 88.19% 87.62% -0.57%
==========================================
Files 10 10
Lines 2491 2506 +15
==========================================
- Hits 2197 2196 -1
- Misses 294 310 +16
Continue to review full report at Codecov.
|
This prepares the crate to be used by a Substrate module without requiring more core crate modules than SRML uses already. The main difficulty is in removing the use of core::fmt.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares the crate to be used by a Substrate module without requiring more core crate modules than SRML uses already. The main difficulty is in removing the use of core::fmt.
Fixes #85.