Conversation
rphmeier
reviewed
Apr 3, 2019
src/lib.rs
Outdated
| pub num_precommits: usize, | ||
| pub num_duplicated_precommits: usize, | ||
| pub num_equivocations: usize, | ||
| pub num_invalid_voters: usize, |
Contributor
There was a problem hiding this comment.
Prefer getters since then we can add more without breaking API or add a _priv field. Doc-strings on the fields would be helpful also.
marcio-diaz
approved these changes
Apr 3, 2019
| Work(Box<FnMut(CommitProcessingOutcome) + Send>), | ||
| } | ||
|
|
||
| #[cfg(test)] |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommunicationOutandCommunicationInare no longer encodable/decodable. The commit inCommunicationOuttakes a callback that is not serializable. In general, these messages won't need to be encoded anyway.Cloneon callback, seemed dangerous and it's only needed for tests.CommitValidationResultpublic.