Merged
Conversation
19 tasks
andresilva
approved these changes
Jul 6, 2021
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
Changes LGTM, just one minor nit regarding version bump. Let me know when this should be merged (since I know the rest of the changes in substrate are still somewhat in flux).
Contributor
Author
|
Happy for this to be merged/released now, so I can remove the |
Contributor
Author
|
Ok for me to merge this now @andresilva? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for work on paritytech/substrate#8370, used in branch https://github.com/paritytech/substrate/compare/aj-metadata-vnext.